Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create <Upload /> Component #54

Open
tko22 opened this issue May 15, 2020 · 1 comment
Open

Create <Upload /> Component #54

tko22 opened this issue May 15, 2020 · 1 comment
Labels
component for component dev issues effort: high help wanted Extra attention is needed not spec'd issue is not fully fleshed out question Further information is requested

Comments

@tko22
Copy link
Member

tko22 commented May 15, 2020

I'm not sure if we should do this.. it's fairly complicated and idk if it's worth doing for the amount of effort vs how many people will use this

Could use https://react-dropzone.js.org/#dropzone (look at stying with styled-components) but here are some concerns:

  • what are the implications of adding another library?
  • I dont think we can do the progress bars, we could make progress bars into a different component? maybe?
@tko22 tko22 added help wanted Extra attention is needed question Further information is requested component for component dev issues not spec'd issue is not fully fleshed out effort: high labels May 15, 2020
@tko22 tko22 mentioned this issue May 15, 2020
7 tasks
@jackieo5023
Copy link
Member

https://programmingwithmosh.com/javascript/react-file-upload-proper-server-side-nodejs-easy/ this may be helpful - haven't looked too much into it, but doesn't look insanely hard. one thing is it doesn't have progress bars, but I agree we can make that into a separate component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component for component dev issues effort: high help wanted Extra attention is needed not spec'd issue is not fully fleshed out question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants