Turn off commit messages

[nufyoot]

Hi Phil,

I think it would be helpful to turn off the commit messages so it shows a cleaner graph. Perhaps just a check box at the top? I'll submit a pull request later tomorrow.

Thanks,
Terry

[haacked]

A checkbox is fine. I use this to teach people Git so a commit message is essential to know which commit is which. People don't memorize SHAs very well. But a checkbox to toggle them sounds cool.

[nufyoot]

Are you sure people don't memorize SHAs? It's even just the first 8 chars of the SHA which should be even easier yet! 😉 I agree to having it optional, and it's just a suggestion. I like the idea of using SeeGit as a tool to teach Git. I'll keep that in mind as I try to transition my team to using git. I just find myself looking at the graph and I'm just looking for a quick overview of how two branches relate to one another (another feature request coming 😄) and the messages clutter up the lines and the graph. I won't be able to submit the pull request tonight, but perhaps by Friday night.

Thanks!

[haacked]

| and the messages clutter up the lines and the graph.

See, I'd rather solve that problem. Not sure how exactly, but I could imagine a layout that ensures that messages don't overlay each other. Or each commit gets it's own spot horizontal slice on the vertical timeline so messages can't overlap.

But I like this idea as a stop gap. :)

[nufyoot]

Agreed. I see that GraphLayout allows you to override CreateVertexControl and CreateEdgeControl. I created an override for CreateVertexControl and set the width and height of the control so that it didn't overlap and that seems to have worked to a certain extent. Now, I just need to get the starting point of the edge to be the middle of the SHA rather than the middle of the text. I'll submit a pull request once I have something that might work.

[haacked]

Sweet! Thanks for helping!

[nufyoot]

Sorry I've been inactive for a bit. I plan on wrapping this up this week and sending a pull request on Friday. Thanks!

[LB--]

Maybe the short message should be shown in place of the commit hash until you hover? It's certainly confusing when I see something like this:

[haacked]

What I'd really like to do is more intelligently lay out the graph so the messages don't overlap too many elements. But I do like the idea of showing the message on hover when showing commit messages is turned off.

[LB--]

I meant not showing the commit hash until mouse-over, and showing a shortened commit message when not moused-over. Example:

Mouse not hovering over:

[Some commit mes...]

Mouse is hovering over:

[caf3de4d] Some commit message explaining the commit

[haacked]

Not even the commit hash? There should be some identifier. Otherwise it's just a bunch of black context-less circles. Can you photoshop (or Paint.NET) up a mockup of what you mean?

[LB--]

With mouse-over:

Without mouse-over:

[Therzok]

Hmmm, shouldn't be that hard. Phil, do you want to handle this or should I?

[Therzok]

Also, would you like this as an option or a built-in feature?

[haacked]

OH, interesting. I wonder if the text should be smaller without the mouse over. That way you can see enough of the commit message to make sense of it. I like this idea. @Therzok feel free man. I am just swamped with other things right now. :)

[LB--]

@Therzok either way, though I can't think of a reason for the option to be disabled unless you wanted to quickly look at a bunch of commit hashes at once for cherry-picking. Thank you :)

[Therzok]

I'll fix up a PR for this in a bit. :D

[Therzok]

So, basically this will include 3 layouts:
Expanded:

• Show SHA and commit message

Not Expanded:

• Current layout on hover
• Show just message when not hovered

[Therzok]

Should have this done today.

[Therzok]

I've got mudded in by exams. I'll finish this somewhere around tomorrow.

[LB--]

That's fine, I also have exams - take your time and good luck!

[Therzok]

@haacked I don't see any other way than to manually handle addition/removal of triggers based on being expanded or not. Tell me if you see any other better way.

In fact, the trigger collection gets sealed so I can't modify it at runtime.

[haacked]

I was thinking you'd just redraw the entire graph if the setting is changed. It's kind of a core level setting. I'm not sure what the "trigger collection" is. ;)

[Therzok]

the trigger collection for the vertex.

Basically, this is different. Not as part of the option, but by
having two layouts, one based on expanded, one on not.

I might be able to set triggers on mouseOver based on
Expanded property bindings.

I'll try and find alternatives.

[haacked]

Is there any reason not to use triggers? I just haven't dug that deeply into it to understand.

[Therzok]

Well. I just realised the dependency property can be used.

I couldn't find a way to use triggers based on the expanded
binding. I now know how. :D

[Therzok]

Aaand, I still don't have time. Swamped with tasks for MonoDevelop. =D

[LB--]

That's perfectly fine, heh. As long as it's done before 2014 I won't complain.

[Therzok]

Well, the internship stops in September, so it's going to be before 2014. Otherwise, if I find time in weekends, I'll make a push.

[LB--]

1.49 hours until 2014! Can we make it?