Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up logging #40

Open
bketelsen opened this issue Mar 1, 2013 · 5 comments
Open

Clean up logging #40

bketelsen opened this issue Mar 1, 2013 · 5 comments
Labels

Comments

@bketelsen
Copy link
Member

Logging is too verbose. Fix logging to make it consistent, possibly add log levels for more verbosity when necessary.

Option: Change log level of running doozerd instances with signals.

@ghost ghost assigned mreiferson Mar 11, 2013
@srid
Copy link
Member

srid commented Mar 25, 2013

@mreiferson - we are looking to implement this (high-prio) feature for stackato and send a pull request. i see that this issue is already assigned to you. do you plan to work on your own, or should we collaborate? let me know also if you want me to work on it instead.

specifically, i want to have log levels (debug, info, warn, error) that can be overridden with command line arguments or signals. could possibly build on top of what i already have.

@bketelsen
Copy link
Member Author

+1 on signals - it's what we use in Skynet for changing log levels.

@mreiferson
Copy link
Contributor

Yea, I did start working on this, I'll push my code up.

I like the idea of using signals, too, I'll add that.

I am interested in some feedback as to what is useful information to log in the default (info) case.

@srid
Copy link
Member

srid commented Mar 25, 2013

that's excellent. i'm looking forward to your changes.

what is useful information to log in the default (info) case.

  • log all API calls (GET, SET, WAIT, ..) from the client? perhaps that belongs to the debug level.
  • log cluster related operations (eg: joining of a node)?

@mreiferson
Copy link
Contributor

sounds reasonable, I'll take a pass and we can discuss over code :)

@mreiferson mreiferson removed their assignment Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants