diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ab74d73..e9bc2de 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -34,9 +34,9 @@ jobs: run: cargo doc --no-deps --workspace --all-features --document-private-items check_msrv: - name: Check MSRV (1.60) + name: Check MSRV (1.68.2) runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: dtolnay/rust-toolchain@1.60 + - uses: dtolnay/rust-toolchain@1.68.2 - run: cargo check --workspace --all-features diff --git a/Cargo.toml b/Cargo.toml index ea1bbc3..683620e 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -9,7 +9,7 @@ documentation = "https://docs.rs/dolly" keywords = ["gamedev", "camera", "3d"] categories = ["game-development"] readme = "crates-io.md" -rust-version = "1.60" +rust-version = "1.68.2" [dependencies] glam = { version = ">=0.21, <=0.28", features = ["mint"] } diff --git a/README.md b/README.md index 447221e..5908fd6 100644 --- a/README.md +++ b/README.md @@ -2,7 +2,7 @@ [![Crates.io](https://img.shields.io/crates/v/dolly.svg)](https://crates.io/crates/dolly) [![Docs](https://docs.rs/dolly/badge.svg)](https://docs.rs/dolly) -[![Rust 1.60](https://img.shields.io/badge/Rust-1.60-fc8d62?logo=rust)](https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1600-2022-04-07) +[![Rust 1.68.2](https://img.shields.io/badge/Rust-1.68.2-blue?logo=rust)](https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1682-2023-03-28) Combine simple building blocks to create smooth cameras: first-person, chase, orbit, look-at, you name it! diff --git a/src/drivers/arm.rs b/src/drivers/arm.rs index 7e62bd0..f2cbbf2 100644 --- a/src/drivers/arm.rs +++ b/src/drivers/arm.rs @@ -9,12 +9,10 @@ use crate::{ /// Offsets the camera along a vector, in the coordinate space of the parent. #[derive(Debug)] pub struct Arm { - /// pub offset: mint::Vector3, } impl Arm { - /// pub fn new(offset: V) -> Self where V: Into>, diff --git a/src/drivers/look_at.rs b/src/drivers/look_at.rs index c1bf618..7b2ea16 100644 --- a/src/drivers/look_at.rs +++ b/src/drivers/look_at.rs @@ -28,7 +28,6 @@ pub struct LookAt { } impl LookAt { - /// pub fn new

(target: P) -> Self where P: Into>, diff --git a/src/drivers/position.rs b/src/drivers/position.rs index 7347a40..572907b 100644 --- a/src/drivers/position.rs +++ b/src/drivers/position.rs @@ -21,7 +21,6 @@ impl Default for Position { } impl Position { - /// pub fn new

(position: P) -> Self where P: Into>, diff --git a/src/rig.rs b/src/rig.rs index 48f3846..7156517 100644 --- a/src/rig.rs +++ b/src/rig.rs @@ -9,23 +9,16 @@ use std::marker::PhantomData; /// A chain of drivers, calculating displacements, and animating in succession. #[derive(Debug)] pub struct CameraRig { - /// pub drivers: Vec>>, - - /// pub final_transform: Transform, - phantom: PhantomData, } // Prevents user calls to `RigDriver::update`. All updates must come from `CameraRig::update`. struct RigUpdateToken; -/// pub struct RigUpdateParams<'a, H: Handedness> { - /// pub parent: &'a Transform, - /// pub delta_time_seconds: f32, phantom: PhantomData, @@ -98,20 +91,17 @@ impl CameraRig { } } -/// pub struct CameraRigBuilder { drivers: Vec>>, phantom: PhantomData, } impl CameraRigBuilder { - /// pub fn with(mut self, driver: impl RigDriverTraits) -> Self { self.drivers.push(Box::new(driver)); self } - /// pub fn build(self) -> CameraRig { let mut rig = CameraRig { drivers: self.drivers, diff --git a/src/transform.rs b/src/transform.rs index af151eb..3871e2c 100644 --- a/src/transform.rs +++ b/src/transform.rs @@ -13,7 +13,6 @@ pub struct Transform { } impl Transform { - /// pub fn from_position_rotation(position: P, rotation: Q) -> Self where P: Into>, @@ -29,7 +28,6 @@ impl Transform { } } - /// pub fn into_position_rotation(self) -> (P, Q) where P: From>, @@ -65,7 +63,6 @@ impl Transform { From::from((rotation * H::FORWARD).into()) } - /// pub const IDENTITY: Transform = Transform { position: mint::Point3 { x: 0.0,