Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuel Fired Generator glitches when stackable-fuel source has a returned item #3

Open
Maverick2797 opened this issue Apr 17, 2020 · 3 comments

Comments

@Maverick2797
Copy link

This is not normally a problem (eg lava bucket is unstackable->only one at a time, coalblock is expected to be consumed) but using a stackable fuel source that returns an item (eg empty glass bottle) causes the formspec to bug out a bit and the "returned" item is not returned anywhere until the slot is empty where only a single "returned" item is actually returned.
Glitching: "Split stacks" toggle and (empty) fuel-inventory blinks.
screenshot_20200417_215311
.
Link to upstream issue: minetest-mods#543 (comment)

@gpcf
Copy link
Collaborator

gpcf commented Jun 8, 2020

I've seen the "splitting stacks" button glitch also on other machines, such as alloy furnaces.

@h-v-smacker
Copy link
Owner

h-v-smacker commented Jun 27, 2020

Regular furnaces do the same BTW — several bottles of ethanol in, only one empty bottle left in the end in the fuel slot.

@h-v-smacker
Copy link
Owner

h-v-smacker commented Jun 27, 2020

Looks like we need a whole new inventory slot for "waste" then. It's doable for generators, but what about fuel-powered furnaces and alloy furnaces? That, or make generators work a bit like self-contained injectors that throw waste out on their own, but then again — what to do with fuel-powered devices and LV tier generators?

Also the replacement system is ridiculous. The replacement is returned by
minetest.get_craft_result(input) → output, decremented_input
in output.replacements until the last item, when it's passed back in decremented_input.items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants