Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output two dots for empty GT values #1

Open
aryarm opened this issue Apr 12, 2023 · 2 comments
Open

output two dots for empty GT values #1

aryarm opened this issue Apr 12, 2023 · 2 comments

Comments

@aryarm
Copy link
Member

aryarm commented Apr 12, 2023

in some cases, HipSTR will output a GT value of .

but it should output ./. instead, according to the VCF spec:

If a call cannot be made for a sample at a given locus, ‘.’ must be specified for each missing allele in the GT field (for example
‘./.’ for a diploid genotype and ‘.’ for haploid genotype).

This might be the line of code where this happens:

empty_gt << ".:";

@yli091230
Copy link
Collaborator

Hi Arya,
Thanks for the note. I noticed the same issue but didn't check the code. I'll fix the code.

@aryarm
Copy link
Member Author

aryarm commented Apr 14, 2023

oooh, thanks for offering to do that, @yli091230 !

@mlamkin7 , would you happen to have a bam or cram file that @yli091230 could use to replicate the issue for a test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants