Project 2 Review

[kamran1310]

Hi Yatao,

Congratulations on finishing Project 2, you have done a great job !!

Your notebook ran just fine on datanotebook.org, no errors at all. The thing I liked about about your approach from the beginning was that you guys chose a dataset with huge number of columns, and did a fabulous job with it. I thought running your queries would take a lot of time considering the fact that it's huge but it didn't, which is a good thing. Queries should be efficient in terms of time and you have ensured that, good job!

The schema diagram looks like a perfect star schema diagram, which is another thing I liked in your notebook. The dimensions make sense and you separated them from the main table properly which again counts as a good thing in the notebook. Your approach was slightly different than mine but that helped me to learn some new tit bits in SQL.

There's only one thing I'd like to point out: I think you guys forgot to add foreign key constraint after creating your fact and dimension tables. Everything else looks fine. Good job !!

Best,

Kamran