Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review for project -01 #1

Open
szuying-yang opened this issue Sep 27, 2016 · 0 comments
Open

review for project -01 #1

szuying-yang opened this issue Sep 27, 2016 · 0 comments

Comments

@szuying-yang
Copy link

szuying-yang commented Sep 27, 2016

Hello Sofia, this is the review I have for your first Project.

Overall, I have no problem unzip your file and get the text in order to run the code. Thank you for arranging it properly so that I can easily begin the review process.
For the first problem set about word counts, I find the way you used “ | “to combine to be intelligent, because when I did the problem, I used separate code to process and I find yours to be much more efficient. One more thing I notice is that for the Part B.; because the exact pattern we are looking for is “Rom. ”, which contains a dot and a space after Rom and Jul, I think it would be more precise if you consider adding these criteria into your searching pattern.
As for the second problem- the Capital Bikeshare problem, my approach is exact the same as yours in both part A and part B.
For the third problem, my method is again almost the same as yours. One thing I learned from viewing your simplefilter python code is the usage of adding space to the strip function that help split words. I would consider using this method next time I encounter this type of problem.
For the extra credit, the way I prepare the text file is the same as yours. However, I would suggest using GNU parallel and append it into a new txt file before sort.
The experience of reviewing your code went on very smoothly. Although I wish I could see more explanations about why you select the method you used, it is still very easy for me to follow your logic and get the result from your code. Thank you for arranging it clearly and I really appreciate the great work you have!

Szu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant