Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review for project-01 #2

Open
JingningLi opened this issue Sep 27, 2016 · 0 comments
Open

Review for project-01 #2

JingningLi opened this issue Sep 27, 2016 · 0 comments

Comments

@JingningLi
Copy link

Hi Livia, this is my review for your Project 1 notebook.

I was able to run your notebook at jupyter notebook just fine.

For problem 1, I think you did well in part a. My answer is larger than you. You consider the duplicate situation which I missed by using "uniq -c" to reduce them. You also write them into one line which is very clean. By the way, I think the last pipe "sort -rn" is not necessary but it is ok for you to write it. I am not sure the answer for part b, because I am confused with the meaning of "speaking lines".

For problem 2, I think you did very well, which is cohesive and clean. I forget to use "uniq -c" again, so I got wrong answer.

For problem 3, it seems that you didn't use '.py' file to replace the related command.

Here is my advise, you can explain your pipeline more clearly in you "#" part next time. Besides, put all your related files into one folder and compress the folder, then upload it to github, which will be more helpful for other people to review. If I have said anything that is not correct, apologize for that.

Thank you!

Jingning Li

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant