You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi Livia, this is my review for your Project 1 notebook.
I was able to run your notebook at jupyter notebook just fine.
For problem 1, I think you did well in part a. My answer is larger than you. You consider the duplicate situation which I missed by using "uniq -c" to reduce them. You also write them into one line which is very clean. By the way, I think the last pipe "sort -rn" is not necessary but it is ok for you to write it. I am not sure the answer for part b, because I am confused with the meaning of "speaking lines".
For problem 2, I think you did very well, which is cohesive and clean. I forget to use "uniq -c" again, so I got wrong answer.
For problem 3, it seems that you didn't use '.py' file to replace the related command.
Here is my advise, you can explain your pipeline more clearly in you "#" part next time. Besides, put all your related files into one folder and compress the folder, then upload it to github, which will be more helpful for other people to review. If I have said anything that is not correct, apologize for that.
Thank you!
Jingning Li
The text was updated successfully, but these errors were encountered:
Hi Livia, this is my review for your Project 1 notebook.
I was able to run your notebook at jupyter notebook just fine.
For problem 1, I think you did well in part a. My answer is larger than you. You consider the duplicate situation which I missed by using "uniq -c" to reduce them. You also write them into one line which is very clean. By the way, I think the last pipe "sort -rn" is not necessary but it is ok for you to write it. I am not sure the answer for part b, because I am confused with the meaning of "speaking lines".
For problem 2, I think you did very well, which is cohesive and clean. I forget to use "uniq -c" again, so I got wrong answer.
For problem 3, it seems that you didn't use '.py' file to replace the related command.
Here is my advise, you can explain your pipeline more clearly in you "#" part next time. Besides, put all your related files into one folder and compress the folder, then upload it to github, which will be more helpful for other people to review. If I have said anything that is not correct, apologize for that.
Thank you!
Jingning Li
The text was updated successfully, but these errors were encountered: