-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sbank v1.0.0 with IMRPhenomT* #43
Comments
@MariaAssiduo, I think the issue is that you are using I think the easiest thing might be for you to install |
@duncanmmacleod Thank you. Quick question, If I do the changes described here in the script /home/maria.assiduo/gwastro7/sbank_Python3/lib/python3.6/site-packages/lalapps/inspiral.py, should I be able to fix the issue? Actually I tried, but it failed. |
Ok, you also need the changes from https://git.ligo.org/lscsoft/lalsuite/-/merge_requests/1694. |
@duncanmmacleod I am unable to make those changes, because I can't find the appropriate scripts in my copy of sbank. But I am really confused, when I install sbank I don't install all needed modules separately. So, when I install the latest version of sbank with git clone, glue is installed automatically (I assume). Then I use the source /home/maria.assiduo/gwastro7/sbank_Python3/bin/activate . Where should I install |
To install source /home/maria.assiduo/gwastro7/sbank_Python3/bin/activate
python -m pip install lscsoft-glue==2.0.0 |
@duncanmmacleod Hi, thank you for your help. After your suggestion I still get this error (CIT dir -> /home/maria.assiduo/test_gwastro7):
I defined them in waveforms.py and tau0tau3.py in a similar way of the approximants IMRPhenomXPHM as I described in the first comment here, I use the latest version of sbank and also conda igwn-py39-20211019. What am I missing? |
@MariaAssiduo The https://github.com/gwastro/sbank/blob/master/sbank/waveforms.py#L1028 which is one of the places you state you have already changed. I would make sure that this change is in the installed code, and that you are sourcing the code you expect. Doing:
should print everything in that block of code. If that fails, you can do:
to get the location of the |
@spxiwh I have error "command not found" when I type Thank you |
@MariaAssiduo I think that "command not found" indicates this is being run directly from the command line and not from within python. My apologies, I should have stated that. Before running any of this you should run:
to open up a python prompt and then run these commands there. (Better to do this from the directory |
@spxiwh Sorry, I did it and seems that the approximants are not properly added in sbank because they do not appear in the list
Thank you |
Okay, so if you do:
from with a |
Hi. I need to use the waveforms IMRPhenomTPHM/TP/THM/T to generate template banks with sbank. In conda igwn-py39- the version of lalsimulation seems to include this waveforms
But I don't know how to use sbank with that waveforms. In case of the approximant IMRPhenomXPHM, I just modified sbank adding the following lines:
in waveforms.py:
in tau0tau3.py:
And I was able to build template banks. In the case of IMRPhenomTPHM I did something similar, but it doesn't work (here a test /home/maria.assiduo/test_gwastro7/TB_TPHM. and I get the error:
).
In the script waveforms.py there is no defined class for IMRPhenomTTemplate... does this mean that in the current sbank version is not implemented IMRPhenom class in time domain?
I am quite confused and need help to understand.
Thank you in advance.
The text was updated successfully, but these errors were encountered: