Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pycbc_make_sky_grid needs to accept angles in both radians and degrees #4986

Closed
pannarale opened this issue Dec 12, 2024 · 0 comments · Fixed by #4988
Closed

pycbc_make_sky_grid needs to accept angles in both radians and degrees #4986

pannarale opened this issue Dec 12, 2024 · 0 comments · Fixed by #4988
Assignees
@titodalcanton

Comments

@pannarale
Copy link
Contributor

pannarale commented Dec 12, 2024 •
edited
Loading

This will bring it in line with #4965 and prevent the workflow generator from only accepting radians.
@pannarale pannarale moved this to In Progress in PyGRB Development Dec 12, 2024
@pannarale pannarale mentioned this issue Dec 12, 2024
Merged
1 task
pannarale added a commit to pannarale/pycbc that referenced this issue Dec 12, 2024
@pannarale
Addessing issue gwastro#4986
4a568c4
@titodalcanton titodalcanton mentioned this issue Dec 13, 2024
Merged
1 task
pannarale added a commit to pannarale/pycbc that referenced this issue Dec 13, 2024
@pannarale
Revert "Addessing issue gwastro#4986"
cb9df75 
This reverts commit 4a568c4.
@github-project-automation github-project-automation bot moved this from In Progress to Done in PyGRB Development Dec 16, 2024
titodalcanton pushed a commit that referenced this issue Dec 19, 2024
@pannarale
Generate and use search sky-grids in pygrb worflows (#4985)
5301a22 
* Prototype to generate and use search sky-grid in pygrb worflows

* Cleanup and follow-up on review comments

* Addessing issue #4986

* Revert "Addessing issue #4986"

This reverts commit 4a568c4.

* ValueError --> RuntimeError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@titodalcanton titodalcanton

Labels
None yet
Projects
PyGRB Development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow RA/dec unit suffix in make_sky_grid titodalcanton/pycbc
2 participants
@titodalcanton @pannarale