Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitch screenshots #35

Open
eleanorisaacs opened this issue Mar 19, 2023 · 3 comments
Open

Twitch screenshots #35

eleanorisaacs opened this issue Mar 19, 2023 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@eleanorisaacs
Copy link

Would it be possible to make this addon work on Twitch livestreams/VODs too? Similar to this chrome extension: https://chrome.google.com/webstore/detail/video-screenshot/ppkojackhibeogijphhfnamhemklmial

@joggee-fr
Copy link
Contributor

Hi @eleanorisaacs,
Technically, the extension could be able to screenshot every HTML <video> tag (if the stream is not DRM-protected). But it has been designed only to retrieve the expected <video> tags for YouTube regular videos and Shorts.

@gurumukhi
Copy link
Owner

@joggee-fr can you quickly check if the code works well on Twitch as it is with just adding its url in manifest. If that's the case then we can think of next steps.

or @PRIXYY, can you give it a try with Twitch?

@joggee-fr
Copy link
Contributor

I am not a Twitch user but I gave it a quick try with the addon enabled. As expected, the controls where the screenshot button is added is located in a different HTML place than in YouTube.

If someone wants to add Twitch support, please take a look at waitForControls() at content_script.js#L176.

@gurumukhi gurumukhi added the help wanted Extra attention is needed label Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants