Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate objects_sketch.SlotArc and rename to objects_sketch.SlotCurve #826

Open
jdegenstein opened this issue Dec 19, 2024 · 0 comments
Open

Deprecate objects_sketch.SlotArc and rename to objects_sketch.SlotCurve #826

jdegenstein opened this issue Dec 19, 2024 · 0 comments
Assignees
@jdegenstein
Milestone
Not Gating Releas...

Comments

@jdegenstein
Copy link
Collaborator

Currently objects_sketch.SlotArc accepts an arbitrary path/curve -- the name is misleading since it implies that only a (presumably circular) arc is acceptable. I propose that objects_sketch.SlotArc is deprecated for near term removal, and that the code is moved to objects_sketch.SlotCurve with a few changes to the docstring / parameters to reflect its general applicability.

Another alternate name idea would be objects_sketch.SlotPath

Are there any other better name ideas for this?
@jdegenstein jdegenstein added this to the Not Gating Release 1.0.0 milestone Dec 19, 2024
@jdegenstein jdegenstein self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdegenstein jdegenstein

Labels
None yet
Projects
None yet
Milestone
Not Gating Release 1.0.0
Development

No branches or pull requests
1 participant
@jdegenstein