Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wire/edge methods position_at, tangent_at, location_at to class Curve #785

Open
jdegenstein opened this issue Nov 13, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jdegenstein
Copy link
Collaborator

Currently the operators @, %, ^ for position_at, tangent_at, location_at are bound to class Curve but the actual methods position_at, tangent_at, location_at are not present

@jdegenstein jdegenstein added the enhancement New feature or request label Nov 13, 2024
@jdegenstein jdegenstein added this to the Not Gating Release 1.0.0 milestone Nov 13, 2024
@gumyr
Copy link
Owner

gumyr commented Nov 19, 2024

Please hold off on this. As part of the refactoring of topology.py (Issue #788) Curve is changing. Still needs some verification but a Curve that can be a Wire is converted to one during the + operation so all the normal Mixin1D methods work for them. If the Curve consists of disconnected Edges then it will be a Compound and these operations don't apply.

@jdegenstein
Copy link
Collaborator Author

Makes sense, and sounds good -- I started working on it briefly and then realized I was creating more entanglements so I stopped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants