Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify check on split_digits to allow for negative numbers #319

Open
ijwok opened this issue May 27, 2024 · 0 comments
Open

Modify check on split_digits to allow for negative numbers #319

ijwok opened this issue May 27, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@ijwok
Copy link

ijwok commented May 27, 2024

Currently, there are checks in place that limit the use of split_digits to the range [0,8] in the OptimalBinning classes.

Is there any reason to not allow for negative numbers here, to allow for rounding to 10s/100s? The numpy.round implementation that is used will happily accept negative numbers to allow for rounding to powers of 10, e.g. numpy.round(1343.21,-2) == 1300.0.

As for the work required, if my understanding is correct the only thing that would need to be changed to allow for this is to adjust the check 0 <= split_digits <= 8 that is present in several parts of the code.

(N.B. this is the first issue I have ever raised, please let me know if this is the correct way of doing so)

@guillermo-navas-palencia guillermo-navas-palencia added the enhancement New feature or request label May 31, 2024
@guillermo-navas-palencia guillermo-navas-palencia added this to the Backlog milestone May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants