From 8496f75a17379a3d871ae7e0005f464fb50e8919 Mon Sep 17 00:00:00 2001 From: Charlotte Date: Thu, 16 Jan 2025 12:02:19 +0000 Subject: [PATCH] update after including merch high position changes --- dotcom-rendering/src/lib/getFrontsAdPositions.test.ts | 4 ++-- dotcom-rendering/src/lib/getFrontsAdPositions.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dotcom-rendering/src/lib/getFrontsAdPositions.test.ts b/dotcom-rendering/src/lib/getFrontsAdPositions.test.ts index 45d81ef048..64e731f211 100644 --- a/dotcom-rendering/src/lib/getFrontsAdPositions.test.ts +++ b/dotcom-rendering/src/lib/getFrontsAdPositions.test.ts @@ -254,13 +254,13 @@ describe('Mobile Ads', () => { { collectionType: 'scrollable/feature', containerLevel: 'Secondary', - }, // Ad position (21) + }, // Ignored - is merch high position { collectionType: 'news/most-popular' }, // Ignored - is most viewed container ]; const mobileAdPositions = getMobileAdPositions(testCollections); - expect(mobileAdPositions).toEqual([0, 4, 6, 8, 10, 14, 19, 21]); + expect(mobileAdPositions).toEqual([0, 4, 6, 8, 10, 14, 19]); }); }); diff --git a/dotcom-rendering/src/lib/getFrontsAdPositions.ts b/dotcom-rendering/src/lib/getFrontsAdPositions.ts index b5b84064eb..b347664fea 100644 --- a/dotcom-rendering/src/lib/getFrontsAdPositions.ts +++ b/dotcom-rendering/src/lib/getFrontsAdPositions.ts @@ -100,7 +100,7 @@ const isEvenIndex = (_collection: unknown, index: number): boolean => * up to a maximum of `MAX_FRONTS_MOBILE_ADS` */ const getMobileAdPositions = (collections: AdCandidate[]): number[] => { - const merchHighPosition = getMerchHighPosition(collections.length); + const merchHighPosition = getMerchHighPosition(collections); const hasSecondaryContainers = hasSecondaryLevelContainers(collections); return (