Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard::Notifier should not be used within child process (formatter) #19

Open
e2 opened this issue Dec 17, 2014 · 3 comments
Open

Guard::Notifier should not be used within child process (formatter) #19

e2 opened this issue Dec 17, 2014 · 3 comments
Assignees
Labels

Comments

@e2
Copy link

e2 commented Dec 17, 2014

Guard::Cucumber uses Guard::Notify from within the Formatter.

While this works (because of how Guard::Notifier passes available notifiers through environment variables - tied to the PID of the parent process, and other horrors), it shouldn't be necessary - notifications should happen after reading the results file within the Runner.

@e2 e2 self-assigned this Dec 17, 2014
@e2 e2 added the bug label Dec 17, 2014
@astery
Copy link

astery commented Mar 7, 2015

Does it related to this error?

@e2
Copy link
Author

e2 commented Mar 7, 2015

@astery - no, that looks like a new bug.

I'd need to know what options are passed to notify. Could you add the following line:

$stderr.puts [msg, options].inspect

As the first line in the self.notify() method here (line 112):

/home/user/.gem/ruby/2.0.0/gems/guard-compat-1.2.1/lib/guard/compat/plugin.rb

Or, if you can create a repo reproducing the problem, I could quickly find the cause and fix it.

@astery
Copy link

astery commented Mar 8, 2015

@e2, thank you for response. I created separated issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants