Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] ClearlyDefined certifier failing on certain packages #2133

Open
1 of 2 tasks
jeffmendoza opened this issue Sep 17, 2024 · 0 comments
Open
1 of 2 tasks

[bug] ClearlyDefined certifier failing on certain packages #2133

jeffmendoza opened this issue Sep 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jeffmendoza
Copy link
Collaborator

jeffmendoza commented Sep 17, 2024

Describe the bug

Sometimes get:

"unable to ingest document due to ingestion error clearlydefined : error assembling graphs for "clearlydefined" : ingestLicenses failed with error: IngestLicenses failed with error: input: ingestLicenses LicenseRef name provided without inline.\n"

To Reproduce

Have a package where ClearlyDefined returns "LicenseRef-scancode-public-domain" or other "LicenseRef..." for the declared or discovered license.

Additional context

  • ClearlyDefined used to only use license identifiers on the SPDX License List and use "NOASSERTION" for any other license.
  • GUAC Ontology is designed to support SPDX License identifiers as well as licenses not on the list using "LicensRef" and the full text of the license (this is how they are included in SPDX SBOMs). The GUAC gql server validates new License nodes upon insertion to the graph to make sure the full text is included if the identifier starts with "LicenseRef"
  • The CD certifier expects all license identifiers to be SPDX identifiers and inserts them into the graph without validation.
  • CD has now added new support for Scancode LicenseRef to support non-SPDX licenses.
  • This means the CD certifier will now attempt to insert those directly, which fails with the message above.

Todo

  • Short term: Have the CD certifier ignore license identifiers that start with "LicenseRef" and not try to create GUAC License nodes for those. The license expression strings can still contain those. Update CD certifier to ignore LicenseRef licenses #2134

  • Later: Investigate the Scancode LicenseRef support in ClearlyDefined and determine how we can get the license text when those are found in CD definitions. Then, update the certifier to put that text into GUAC License nodes when "LicenseRef" identifiers are found.

@jeffmendoza jeffmendoza added the bug Something isn't working label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant