Updated to UniversalIO #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekmedia
requested changes
Mar 28, 2024
| if (!widget.style.nativeControls || | ||
| !kIsWeb && Platform.isLinux) | ||
| SizedBox(width: widget.style.titlebarSpace), | ||
| if (!widget.style.nativeControls || !kIsWeb && Platform.isLinux) SizedBox(width: widget.style.titlebarSpace), |
There was a problem hiding this comment.
Can you please format this file with line characters as 80, see this for more:
https://dart.dev/tools/linter-rules/lines_longer_than_80_chars
| @@ -13,15 +13,14 @@ class AdwScaffold extends StatefulWidget { | |||
| this.flapStyle, | |||
| this.flapOptions, | |||
| this.flapController, | |||
| @Deprecated('headerbar is deprecated, use the properties separately') | |||
| AdwHeaderBar? Function(Widget?)? headerbar, | |||
| @Deprecated('headerbar is deprecated, use the properties separately') AdwHeaderBar? Function(Widget?)? headerbar, | |||
|
@NextdoorPsycho The PR looks good but the formatting is wrong, please format with respect to line limit 80 characters. |
|
You could literally just merge it and make a version bump on your IDE and
just visiting the page will make it auto format to 80.
…On Thu, Mar 28, 2024 at 13:19 Prateek Sunal ***@***.***> wrote:
@NextdoorPsycho <https://github.com/NextdoorPsycho> The PR looks good but
the formatting is wrong, please format with respect to line limit 80
characters.
—
Reply to this email directly, view it on GitHub
<#90 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG7WI7A4553UR7KP77MJP43Y2RGLBAVCNFSM6AAAAABERNYY4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRVG4ZTGNZUGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
prateekmedia
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Universal IO package, then updates your imports.
its the same thing, but it works on all platforms.
Cheers!