Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyperlink to oscar when seats button clicked #222

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

EBruda
Copy link

@EBruda EBruda commented Apr 6, 2023

Summary

Updated the hyperlinks (see #220)

How to Test

Run gt-scheduler locally and add a class section. Then, click on the seats button for each section. Ensure that the OSCAR tab opened has the correct term and the class section matches the one in gt-scheduler.

@jazeved0 jazeved0 linked an issue Apr 7, 2023 that may be closed by this pull request
@jazeved0 jazeved0 marked this pull request as ready for review April 7, 2023 01:31
src/components/Prerequisite/index.tsx Outdated Show resolved Hide resolved
src/components/Prerequisite/index.tsx Outdated Show resolved Hide resolved
Comment on lines +149 to +155
const infoAction = {
icon: faInfoCircle,
href:
`https://oscar.gatech.edu/pls/bprod/bwckctlg.p_disp_` +
`course_detail?cat_term_in=${course.term}&subj_code_in=` +
`${course.subject}&crse_numb_in=${course.number}`,
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be added back in to the actions prop of the <ActionRow> component.

This seems to look pretty nice (adding infoAction after prereqAction):

        actions={
          isSearching
            ? [{ icon: faPlus, onClick: onAddCourse }, prereqAction]
            : [
                {
                  icon: expanded ? faAngleUp : faAngleDown,
                  onClick: (): void => prereqControl(false, !expanded),
                },
                prereqAction,
                infoAction,
                {
                  icon: faPalette,
                  onClick: (): void => setPaletteShown(!paletteShown),
                },
                ...

This results in:

image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, thank you!

@jazeved0
Copy link
Member

jazeved0 commented Apr 7, 2023

A couple small changes are needed to make the PR pass CI (see the failures here).

I left comments on each, they should be fairly minor.

@nhatnghiho
Copy link
Contributor

nhatnghiho commented Apr 7, 2023

Thanks for working on this issue @EBruda (and for reviewing too @jazeved0)! We actually deliberately removed the hyperlink to Oscar when we migrated GT Scheduler's crawler to the new registration system. This is because we received intel from OIT that Banner 8, the software that powers the old Oscar, will reach its end of life soon. As a result, the https://oscar.gatech.edu/bprod/bwckschd.p_disp_detail_sched site would probably be taken down in the near future, and Banner 9 (i.e., new Oscar) has no alternative. We're still working with OIT to get better information but for now, we decided to remove support for the hyperlink due to the uncertainty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seats button not working
3 participants