Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor UI Enhancements for Invitation Modal #208

Open
2 tasks done
nhatnghiho opened this issue Mar 14, 2023 · 0 comments
Open
2 tasks done

Minor UI Enhancements for Invitation Modal #208

nhatnghiho opened this issue Mar 14, 2023 · 0 comments
Assignees
@EmilyAL001
Labels
task Task issue for a current or past sprint

Comments

@nhatnghiho
Copy link
Contributor

nhatnghiho commented Mar 14, 2023 •
edited by EmilyAL001
Loading

Description

We had some small design changes for Invitation Modal to implement, which are:

  • Delete confirmation: When user wants to remove someone from viewing their schedule, we want to display a popup confirmation.
  • Text for no friends invited: When user has not invited anyone to their schedule, no emails show up and the bottom of the invitation modal is just a weird blank space. This can confuse users as an error. We want to display some background text to indicate to users that no users have been invited.

Acceptance Criteria

  • Popup is displayed with the email of the user's about to be removed.
  • When no friends have been invited to the current schedule, a text is displayed in the background as a holder.
@nhatnghiho nhatnghiho added the task Task issue for a current or past sprint label Mar 14, 2023
@EmilyAL001 EmilyAL001 self-assigned this Mar 17, 2023
@EmilyAL001 EmilyAL001 mentioned this issue Mar 30, 2023
Merged
2 tasks
samarth52 added a commit that referenced this issue Oct 19, 2023
@EmilyAL001 @samarth52
Emily/208 minor UI enhancements (#214)
a225009 
### Summary

Resolves #208 

<!-- What does this PR change and why? Discuss any breaking changes. -->
Adds a popup modal when the user attempts to remove a user they invited
to share their schedule
Adds text to inform a user that they have to invite someone when they
haven't invited anyone

### Checklist

- [ ] Popup is displayed with the email of the user's about to be
removed.
- [ ] When no friends have been invited to the current schedule, a text
is displayed in the background as a holder.


### How to Test
<!-- Describe how to test your code. -->
Open the "Share Schedule" modal from the "export" tab in the action bar
Click on the "x" to remove a user and the remove modal should pop up

Remove all users from the list of invited users, and the prompting text
should be visible

---------

Co-authored-by: Samarth Chandna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EmilyAL001 EmilyAL001

Labels
task Task issue for a current or past sprint
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nhatnghiho @EmilyAL001