Skip to content
This repository has been archived by the owner on Apr 26, 2021. It is now read-only.

Type check for the properties #12

Open
kshychko opened this issue Mar 4, 2020 · 6 comments
Open

Type check for the properties #12

kshychko opened this issue Mar 4, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@kshychko
Copy link
Contributor

kshychko commented Mar 4, 2020

By mistake I generated my project in interchange format with "description":false instead of "description": "" properties. That didn't cause the project generation failure, but Relationships model wasn't working.
We need to add a type check for the properties which are translated from interchange to starUML to avoid unexpected behavior as above.
Probably the best option would be to develop a json schema for the interchange format, so other tools can use it in order to test their output in interchange format.

This is a good to have option. Development and scope needs to be approved.
@onthebreeze , please provide your comment.

@kshychko kshychko added the enhancement New feature or request label Mar 4, 2020
@kshychko
Copy link
Contributor Author

kshychko commented Mar 4, 2020

icf-samples.zip
The zip with the samples to reproduce the issue.

@faizanvahevaria
Copy link
Contributor

faizanvahevaria commented Mar 4, 2020

@kshychko

By mistake I generated my project in interchange format with "description":false instead of "description": "" properties. That didn't cause the project generation failure, but Relationships model wasn't working.

Above behaviour is handled.
I have query that before steven replay can you please give me simple example how interchange format will look after it is converted in json schema?

@kshychko
Copy link
Contributor Author

kshychko commented Mar 4, 2020

@faizanvahevaria , something like one of the examples here - https://json-schema.org/learn/miscellaneous-examples.html

@faizanvahevaria
Copy link
Contributor

@kshychko
I handled

"description": ""

and updated the code.
I start working on git untill @onthebreeze replay to convert interchange format in json-schema.

@faizanvahevaria
Copy link
Contributor

latest code is updated in version 0.1.5

@kshychko
Copy link
Contributor Author

@onthebreeze approved the schema development for the interchange format.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants