Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicating slots with uuids does not work #13

Open
nomisum opened this issue Aug 6, 2018 · 3 comments
Open

Duplicating slots with uuids does not work #13

nomisum opened this issue Aug 6, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@nomisum
Copy link
Contributor

nomisum commented Aug 6, 2018

Das ging schief as soon as you duplicate slots already taken.
@nomisum nomisum added the bug Something isn't working label Aug 6, 2018
@nomisum
Copy link
Contributor Author

nomisum commented Sep 16, 2018

this is because uuids are not stripped when duplicating

@DerZade DerZade self-assigned this Oct 25, 2018
@nomisum
Copy link
Contributor Author

nomisum commented Jul 16, 2019

there seem to exist 2 duplicate fncs:

https://github.com/gruppe-adler/slotting.gruppe-adler.de/blob/master/src/app/slotting/edit/components/slot.component.ts#L119

https://github.com/gruppe-adler/slotting.gruppe-adler.de/blob/master/src/app/slotting/edit/components/context-menu.component.ts#L88

my guess: second one would need to iterate through all children and remove uuids

@nomisum
Copy link
Contributor Author

nomisum commented Jul 16, 2019

i think i need some help here @DerZade , should be more or less trivial for you

@DerZade DerZade removed their assignment Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nomisum @DerZade