From da069695740db0cb64150641274705402124b447 Mon Sep 17 00:00:00 2001 From: George Barnett Date: Fri, 20 Dec 2024 11:45:54 +0000 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Gus Cairo --- dev/protos/generate.sh | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/dev/protos/generate.sh b/dev/protos/generate.sh index 9474e0f..5cdfe38 100755 --- a/dev/protos/generate.sh +++ b/dev/protos/generate.sh @@ -98,8 +98,6 @@ function generate_reflection_service { local proto="$here/upstream/grpc/reflection/v1/reflection.proto" local output="$root/Sources/GRPCReflectionService/Generated" - # Messages were accidentally leaked into public API, they shouldn't be but we - # can't undo that change until the next major version. generate_message "$proto" "$(dirname "$proto")" "$output" "Visibility=Package" "UseAccessLevelOnImports=true" generate_grpc "$proto" "$(dirname "$proto")" "$output" "Visibility=Package" "UseAccessLevelOnImports=true" } @@ -126,7 +124,7 @@ function generate_health_service_descriptor_set { --include_imports } -function generate_extended_message_descriptor_set { +function generate_base_message_descriptor_set { local proto="$here/tests/reflection/base_message.proto" local proto_path="$here/tests/reflection" local output="$root/Tests/GRPCReflectionServiceTests/Generated/DescriptorSets/base_message.pb" @@ -154,5 +152,5 @@ generate_reflection_service generate_reflection_service_descriptor_set generate_health_service_descriptor_set -generate_extended_message_descriptor_set +generate_base_message_descriptor_set generate_message_with_dependency_descriptor_set