From 04e4f2455d788ac17dcd9b510b0f509da6e61913 Mon Sep 17 00:00:00 2001 From: Colin Alworth Date: Mon, 28 Oct 2024 11:36:36 -0500 Subject: [PATCH] Remove java.util.logging from AsyncServletOutputStreamWriter.Log Comments suggest that this API cannot be referenced, but a new method in the interface still used it. --- .../io/grpc/servlet/AsyncServletOutputStreamWriter.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java b/servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java index cfd29b1a2fd..663cc108545 100644 --- a/servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java +++ b/servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java @@ -32,7 +32,6 @@ import java.util.concurrent.locks.LockSupport; import java.util.function.BiFunction; import java.util.function.BooleanSupplier; -import java.util.logging.Level; import java.util.logging.Logger; import javax.annotation.CheckReturnValue; import javax.annotation.Nullable; @@ -88,8 +87,8 @@ final class AsyncServletOutputStreamWriter { Logger logger = Logger.getLogger(AsyncServletOutputStreamWriter.class.getName()); this.log = new Log() { @Override - public boolean isLoggable(Level level) { - return logger.isLoggable(level); + public boolean isFinestLoggable() { + return logger.isLoggable(FINEST); } @Override @@ -111,7 +110,7 @@ public void finest(String str, Object... params) { this.writeAction = (byte[] bytes, Integer numBytes) -> () -> { outputStream.write(bytes, 0, numBytes); transportState.runOnTransportThread(() -> transportState.onSentBytes(numBytes)); - if (log.isLoggable(Level.FINEST)) { + if (log.isFinestLoggable()) { log.finest("outbound data: length={0}, bytes={1}", numBytes, toHexString(bytes, numBytes)); } }; @@ -253,7 +252,7 @@ interface ActionItem { @VisibleForTesting // Lincheck test can not run with java.util.logging dependency. interface Log { - default boolean isLoggable(Level level) { + default boolean isFinestLoggable() { return false; }