Skip to content

Commit 5669def

Browse files
committed
some todos for questions
1 parent 044b18a commit 5669def

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/groundlight/client.py

+5
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,8 @@ def get_detector(self, id: Union[str, Detector], **kwargs) -> Detector: # pylin
280280
return Detector.parse_obj(obj.to_dict())
281281

282282
def get_detector_by_name(self, name: str) -> Detector:
283+
# TODO should methods like this (which make direct requests instead of going through the API) allow
284+
# kwargs to be passed through?
283285
"""
284286
Get a Detector by name.
285287
@@ -984,6 +986,9 @@ def wait_for_confident_result(
984986
confidence_threshold: Optional[float] = None,
985987
timeout_sec: float = 30.0,
986988
) -> ImageQuery:
989+
# TODO should this method allow request_timeout to be passed in kwargs?
990+
# It's a weird case because it might make multiple requests - would the specified request_timeout be applied
991+
# to each request?
987992
"""
988993
Waits for an image query result's confidence level to reach the specified confidence_threshold.
989994
Uses polling with exponential back-off to check for results.

0 commit comments

Comments
 (0)