diff --git a/.pylintrc b/.pylintrc new file mode 100644 index 00000000..f0082e3e --- /dev/null +++ b/.pylintrc @@ -0,0 +1,427 @@ +[MASTER] + +# A comma-separated list of package or module names from where C extensions may +# be loaded. Extensions are loading into the active Python interpreter and may +# run arbitrary code +extension-pkg-whitelist= + +# Add files or directories to the blacklist. They should be base names, not +# paths. +ignore=CVS + +# Add files or directories matching the regex patterns to the blacklist. The +# regex matches against base names, not paths. +ignore-patterns= + +# Python code to execute, usually for sys.path manipulation such as +# pygtk.require(). +#init-hook= + +# Use multiple processes to speed up Pylint. +jobs=4 + +# List of plugins (as comma separated values of python modules names) to load, +# usually to register additional checkers. +load-plugins= + +# Pickle collected data for later comparisons. +persistent=yes + +# Specify a configuration file. +#rcfile= + +# Allow loading of arbitrary C extensions. Extensions are imported into the +# active Python interpreter and may run arbitrary code. +unsafe-load-any-extension=no + + +[MESSAGES CONTROL] + +# Only show warnings with the listed confidence levels. Leave empty to show +# all. Valid levels: HIGH, INFERENCE, INFERENCE_FAILURE, UNDEFINED +confidence= + +# Disable the message, report, category or checker with the given id(s). You +# can either give multiple identifiers separated by comma (,) or put this +# option multiple times (only on the command line, not in the configuration +# file where it should appear only once).You can also use "--disable=all" to +# disable everything first and then reenable specific checks. For example, if +# you want to run only the similarities checker, you can use "--disable=all +# --enable=similarities". If you want to run only the classes checker, but have +# no Warning level messages displayed, use"--disable=all --enable=classes +# --disable=W" +#disable=print-statement,parameter-unpacking,unpacking-in-except,old-raise-syntax,backtick,long-suffix,old-ne-operator,old-octal-literal,import-star-module-level,raw-checker-failed,bad-inline-option,locally-disabled,locally-enabled,file-ignored,suppressed-message,useless-suppression,deprecated-pragma,apply-builtin,basestring-builtin,buffer-builtin,cmp-builtin,coerce-builtin,execfile-builtin,file-builtin,long-builtin,raw_input-builtin,reduce-builtin,standarderror-builtin,unicode-builtin,xrange-builtin,coerce-method,delslice-method,getslice-method,setslice-method,no-absolute-import,old-division,dict-iter-method,dict-view-method,next-method-called,metaclass-assignment,indexing-exception,raising-string,reload-builtin,oct-method,hex-method,nonzero-method,cmp-method,input-builtin,round-builtin,intern-builtin,unichr-builtin,map-builtin-not-iterating,zip-builtin-not-iterating,range-builtin-not-iterating,filter-builtin-not-iterating,using-cmp-argument,eq-without-hash,div-method,idiv-method,rdiv-method,exception-message-attribute,invalid-str-codec,sys-max-int,bad-python3-import,deprecated-string-function,deprecated-str-translate-call +disable=unused-variable,fixme,relative-import + +# Enable the message, report, category or checker with the given id(s). You can +# either give multiple identifier separated by comma (,) or put this option +# multiple time (only on the command line, not in the configuration file where +# it should appear only once). See also the "--disable" option for examples. +enable= + + +[REPORTS] + +# Python expression which should return a note less than 10 (10 is the highest +# note). You have access to the variables errors warning, statement which +# respectively contain the number of errors / warnings messages and the total +# number of statements analyzed. This is used by the global evaluation report +# (RP0004). +evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10) + +# Template used to display messages. This is a python new-style format string +# used to format the message information. See doc for all details +#msg-template= + +# Set the output format. Available formats are text, parseable, colorized, json +# and msvs (visual studio).You can also give a reporter class, eg +# mypackage.mymodule.MyReporterClass. +output-format=text + +# Tells whether to display a full report or only the messages +reports=no + +# Activate the evaluation score. +score=yes + + +[REFACTORING] + +# Maximum number of nested blocks for function / method body +max-nested-blocks=5 + + +[FORMAT] + +# Expected format of line ending, e.g. empty (any line ending), LF or CRLF. +expected-line-ending-format= + +# Regexp for a line that is allowed to be longer than the limit. +ignore-long-lines=^\s*(# )??$ + +# Number of spaces of indent required inside a hanging or continued line. +indent-after-paren=4 + +# String used as indentation unit. This is usually " " (4 spaces) or "\t" (1 +# tab). +indent-string=' ' + +# Maximum number of characters on a single line. +max-line-length=100 + +# Maximum number of lines in a module +max-module-lines=1000 + +# List of optional constructs for which whitespace checking is disabled. `dict- +# separator` is used to allow tabulation in dicts, etc.: {1 : 1,\n222: 2}. +# `trailing-comma` allows a space between comma and closing bracket: (a, ). +# `empty-line` allows space-only lines. +no-space-check=trailing-comma,dict-separator + +# Allow the body of a class to be on the same line as the declaration if body +# contains single statement. +single-line-class-stmt=no + +# Allow the body of an if to be on the same line as the test if there is no +# else. +single-line-if-stmt=no + + +[SPELLING] + +# Spelling dictionary name. Available dictionaries: de_DE (myspell), de_AT +# (myspell), de_CH (myspell), de_BE (myspell), de_LU (myspell), en_US +# (myspell), de_LI (myspell). +spelling-dict= + +# List of comma separated words that should not be checked. +spelling-ignore-words= + +# A path to a file that contains private dictionary; one word per line. +spelling-private-dict-file= + +# Tells whether to store unknown words to indicated private dictionary in +# --spelling-private-dict-file option instead of raising a message. +spelling-store-unknown-words=no + + +[TYPECHECK] + +# List of decorators that produce context managers, such as +# contextlib.contextmanager. Add to this list to register other decorators that +# produce valid context managers. +contextmanager-decorators=contextlib.contextmanager + +# List of members which are set dynamically and missed by pylint inference +# system, and so shouldn't trigger E1101 when accessed. Python regular +# expressions are accepted. +generated-members= + +# Tells whether missing members accessed in mixin class should be ignored. A +# mixin class is detected if its name ends with "mixin" (case insensitive). +ignore-mixin-members=yes + +# This flag controls whether pylint should warn about no-member and similar +# checks whenever an opaque object is returned when inferring. The inference +# can return multiple potential results while evaluating a Python object, but +# some branches might not be evaluated, which results in partial inference. In +# that case, it might be useful to still emit no-member and other checks for +# the rest of the inferred objects. +ignore-on-opaque-inference=yes + +# List of class names for which member attributes should not be checked (useful +# for classes with dynamically set attributes). This supports the use of +# qualified names. +ignored-classes=optparse.Values,thread._local,_thread._local + +# List of module names for which member attributes should not be checked +# (useful for modules/projects where namespaces are manipulated during runtime +# and thus existing member attributes cannot be deduced by static analysis. It +# supports qualified module names, as well as Unix pattern matching. +ignored-modules= + +# Show a hint with possible names when a member name was not found. The aspect +# of finding the hint is based on edit distance. +missing-member-hint=yes + +# The minimum edit distance a name should have in order to be considered a +# similar match for a missing member name. +missing-member-hint-distance=1 + +# The total number of similar names that should be taken in consideration when +# showing a hint for a missing member. +missing-member-max-choices=1 + + +[MISCELLANEOUS] + +# List of note tags to take in consideration, separated by a comma. +notes=FIXME,XXX,TODO + + +[LOGGING] + +# Logging modules to check that the string format arguments are in logging +# function parameter format +logging-modules=logging + + +[SIMILARITIES] + +# Ignore comments when computing similarities. +ignore-comments=yes + +# Ignore docstrings when computing similarities. +ignore-docstrings=yes + +# Ignore imports when computing similarities. +ignore-imports=no + +# Minimum lines number of a similarity. +min-similarity-lines=4 + + +[VARIABLES] + +# List of additional names supposed to be defined in builtins. Remember that +# you should avoid to define new builtins when possible. +additional-builtins= + +# Tells whether unused global variables should be treated as a violation. +allow-global-unused-variables=no + +# List of strings which can identify a callback function by name. A callback +# name must start or end with one of those strings. +callbacks=cb_,_cb + +# A regular expression matching the name of dummy variables (i.e. expectedly +# not used). +dummy-variables-rgx=_+$|(_[a-zA-Z0-9_]*[a-zA-Z0-9]+?$)|dummy|^ignored_|^unused_ + +# Argument names that match this expression will be ignored. Default to name +# with leading underscore +ignored-argument-names=_.*|^ignored_|^unused_ + +# Tells whether we should check for unused import in __init__ files. +init-import=no + +# List of qualified module names which can have objects that can redefine +# builtins. +redefining-builtins-modules=six.moves,future.builtins + + +[BASIC] + +# Naming hint for argument names +argument-name-hint=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ + +# Regular expression matching correct argument names +argument-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ + +# Naming hint for attribute names +attr-name-hint=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ + +# Regular expression matching correct attribute names +attr-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ + +# Bad variable names which should always be refused, separated by a comma +bad-names=foo,bar,baz,toto,tutu,tata + +# Naming hint for class attribute names +class-attribute-name-hint=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$ + +# Regular expression matching correct class attribute names +class-attribute-rgx=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$ + +# Naming hint for class names +class-name-hint=[A-Z_][a-zA-Z0-9]+$ + +# Regular expression matching correct class names +class-rgx=[A-Z_][a-zA-Z0-9]+$ + +# Naming hint for constant names +const-name-hint=(([A-Z_][A-Z0-9_]*)|(__.*__))$ + +# Regular expression matching correct constant names +const-rgx=(([A-Z_][A-Z0-9_]*)|(__.*__)|(urls|urlpatterns|register))$ + +# Minimum line length for functions/classes that require docstrings, shorter +# ones are exempt. +docstring-min-length=-1 + +# Naming hint for function names +function-name-hint=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ + +# Regular expression matching correct function names +function-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ + +# Good variable names which should always be accepted, separated by a comma +good-names=i,j,k,ex,Run,_,qs + +# Include a hint for the correct naming format with invalid-name +include-naming-hint=no + +# Naming hint for inline iteration names +inlinevar-name-hint=[A-Za-z_][A-Za-z0-9_]*$ + +# Regular expression matching correct inline iteration names +inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$ + +# Naming hint for method names +method-name-hint=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ + +# Regular expression matching correct method names +method-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ + +# Naming hint for module names +module-name-hint=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$ + +# Regular expression matching correct module names +module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$ + +# Colon-delimited sets of names that determine each other's naming style when +# the name regexes allow several styles. +name-group= + +# Regular expression which should only match function or class names that do +# not require a docstring. +no-docstring-rgx=^_ + +# List of decorators that produce properties, such as abc.abstractproperty. Add +# to this list to register other decorators that produce valid properties. +property-classes=abc.abstractproperty + +# Naming hint for variable names +variable-name-hint=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ + +# Regular expression matching correct variable names +variable-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ + + +[IMPORTS] + +# Allow wildcard imports from modules that define __all__. +allow-wildcard-with-all=no + +# Analyse import fallback blocks. This can be used to support both Python 2 and +# 3 compatible code, which means that the block might have code that exists +# only in one or another interpreter, leading to false positives when analysed. +analyse-fallback-blocks=no + +# Deprecated modules which should not be used, separated by a comma +deprecated-modules=optparse,tkinter.tix + +# Create a graph of external dependencies in the given file (report RP0402 must +# not be disabled) +ext-import-graph= + +# Create a graph of every (i.e. internal and external) dependencies in the +# given file (report RP0402 must not be disabled) +import-graph= + +# Create a graph of internal dependencies in the given file (report RP0402 must +# not be disabled) +int-import-graph= + +# Force import order to recognize a module as part of the standard +# compatibility libraries. +known-standard-library= + +# Force import order to recognize a module as part of a third party library. +known-third-party=enchant + + +[DESIGN] + +# Maximum number of arguments for function / method +max-args=5 + +# Maximum number of attributes for a class (see R0902). +max-attributes=7 + +# Maximum number of boolean expressions in a if statement +max-bool-expr=5 + +# Maximum number of branch for function / method body +max-branches=12 + +# Maximum number of locals for function / method body +max-locals=15 + +# Maximum number of parents for a class (see R0901). +max-parents=7 + +# Maximum number of public methods for a class (see R0904). +max-public-methods=20 + +# Maximum number of return / yield for function / method body +max-returns=6 + +# Maximum number of statements in function / method body +max-statements=50 + +# Minimum number of public methods for a class (see R0903). +min-public-methods=2 + + +[CLASSES] + +# List of method names used to declare (i.e. assign) instance attributes. +defining-attr-methods=__init__,__new__,setUp + +# List of member names, which should be excluded from the protected access +# warning. +exclude-protected=_asdict,_fields,_replace,_source,_make + +# List of valid names for the first argument in a class method. +valid-classmethod-first-arg=cls + +# List of valid names for the first argument in a metaclass class method. +valid-metaclass-classmethod-first-arg=mcs + + +[EXCEPTIONS] + +# Exceptions that will emit a warning when being caught. Defaults to +# "Exception" +overgeneral-exceptions=Exception diff --git a/.travis.yml b/.travis.yml new file mode 100644 index 00000000..45519d2f --- /dev/null +++ b/.travis.yml @@ -0,0 +1,17 @@ +language: python + +python: + - "2.7" + +install: + - pip install -r requirements.txt + +jobs: + include: + - stage: pep8 + before_script: pip install pep8 + script: pep8 --show-pep8 --max-line-length=100 --exclude=data . + + - stage: pylint + before_script: pip install pylint + script: pylint --disable=C,R osm2gtfs diff --git a/__init__.py b/__init__.py new file mode 100644 index 00000000..e69de29b diff --git a/core/cache.py b/core/cache.py index 7e2e4f53..f8324ea5 100644 --- a/core/cache.py +++ b/core/cache.py @@ -18,8 +18,8 @@ def write_data(name, content): hard drive. """ - if not os.path.isdir('data'): #checking is the dir exist - os.mkdir('data') + if not os.path.isdir('data'): # checking is the dir exist + os.mkdir('data') with open('data/' + name + '.pkl', 'wb') as f: pickle.dump(content, f, pickle.HIGHEST_PROTOCOL) diff --git a/core/configuration.py b/core/configuration.py index 2b86de05..da1d9617 100644 --- a/core/configuration.py +++ b/core/configuration.py @@ -4,7 +4,6 @@ import sys import json import datetime -import logging from calendar import monthrange @@ -103,7 +102,6 @@ def _prepare_dates(self): except ValueError, e: sys.stderr.write( 'Warning: "start_date" from config file %s\n' % str(e)) - pass if not start_date: # Use first of current month if no start date was specified @@ -124,7 +122,6 @@ def _prepare_dates(self): except ValueError, e: sys.stderr.write( 'Warning: "end_date" from config file %s\n' % str(e)) - pass if not end_date: diff --git a/creators/feed_info_creator.py b/creators/feed_info_creator.py index 016f744d..64e1a451 100644 --- a/creators/feed_info_creator.py +++ b/creators/feed_info_creator.py @@ -20,6 +20,7 @@ def add_feed_info_to_schedule(self, schedule): # Missing feed_info workaround (https://github.com/google/transitfeed/issues/395) # noinspection PyProtectedMember + # pylint: disable=protected-access schedule.AddTableColumns('feed_info', feed_info._ColumnNames()) def prepare_feed_info(self): diff --git a/creators/fenix/trips_creator_fenix.py b/creators/fenix/trips_creator_fenix.py index 6db84042..c950c46f 100644 --- a/creators/fenix/trips_creator_fenix.py +++ b/creators/fenix/trips_creator_fenix.py @@ -75,7 +75,8 @@ def add_trips_to_schedule(self, schedule, data): route.last_update = datetime.strptime(linha['alterado_em'], "%d/%m/%Y") # save duration if linha['tempo_de_percurso'].encode('utf-8') == NO_DURATION: - sys.stderr.write("ERROR: Route has no duration in Fenix data: " + str(route) + "\n") + sys.stderr.write( + "ERROR: Route has no duration in Fenix data: " + str(route) + "\n") continue duration_str = linha['tempo_de_percurso'].replace('aproximado', '') (hours, tmp, minutes) = duration_str.partition(':') diff --git a/creators/incofer/trips_creator_incofer.py b/creators/incofer/trips_creator_incofer.py index 7e3c5ffe..654f4184 100644 --- a/creators/incofer/trips_creator_incofer.py +++ b/creators/incofer/trips_creator_incofer.py @@ -1,11 +1,11 @@ # coding=utf-8 -import sys import json -import transitfeed from datetime import datetime + +import transitfeed + from creators.trips_creator import TripsCreator -from core.osm_routes import Route, RouteMaster class TripsCreatorIncofer(TripsCreator): diff --git a/creators/stops_creator.py b/creators/stops_creator.py index 3b61727e..13c2cbaa 100644 --- a/creators/stops_creator.py +++ b/creators/stops_creator.py @@ -38,28 +38,28 @@ def add_stops_to_schedule(self, schedule, data): # Add loose stop objects to route objects self.add_stops_to_routes(data) - def add_stop(this, schedule, stop, parent_station=None, is_station=False): + def add_stop(self, schedule, stop, parent_station=None, is_station=False): - stop_dict = {"stop_lat": float(stop.lat), - "stop_lon": float(stop.lon), - "stop_name": stop.name} + stop_dict = {"stop_lat": float(stop.lat), + "stop_lon": float(stop.lon), + "stop_name": stop.name} - if is_station: - stop_dict["stop_id"] = "SA" + str(stop.id) - stop_dict["location_type"] = "1" - else: - stop_dict["stop_id"] = str(stop.id) - stop_dict["location_type"] = "" + if is_station: + stop_dict["stop_id"] = "SA" + str(stop.id) + stop_dict["location_type"] = "1" + else: + stop_dict["stop_id"] = str(stop.id) + stop_dict["location_type"] = "" - if parent_station is None: - stop_dict["parent_station"] = "" - else: - stop_dict["parent_station"] = parent_station.stop_id + if parent_station is None: + stop_dict["parent_station"] = "" + else: + stop_dict["parent_station"] = parent_station.stop_id - # Add stop to GTFS object - stop = transitfeed.Stop(field_dict=stop_dict) - schedule.AddStopObject(stop) - return stop + # Add stop to GTFS object + stop = transitfeed.Stop(field_dict=stop_dict) + schedule.AddStopObject(stop) + return stop def add_stops_to_routes(self, data): @@ -101,5 +101,5 @@ def _get_stop(self, stop_id, stops): elif type(elem) is StopArea: if stop_id in elem.stop_members: return elem.stop_members[stop_id] - else: - raise RuntimeError("Unknown stop: " + str(stop)) + else: + raise RuntimeError("Unknown stop: " + str(stop_id)) diff --git a/osm2gtfs.py b/osm2gtfs.py index b8029c33..50c544f5 100755 --- a/osm2gtfs.py +++ b/osm2gtfs.py @@ -85,7 +85,7 @@ def add_feed_info(schedule, output_file): Add feed_info.txt file to GTFS Workaround for https://github.com/google/transitfeed/issues/395 """ - if 'feed_info' not in schedule._table_columns: + if 'feed_info' not in schedule._table_columns: # pylint: disable=protected-access return with transitfeed.zipfile.ZipFile(output_file, 'a') as archive: @@ -94,6 +94,7 @@ def add_feed_info(schedule, output_file): columns = schedule.GetTableColumns('feed_info') writer.writerow(columns) writer.writerow([transitfeed.util.EncodeUnicode(schedule.feed_info[c]) for c in columns]) + # pylint: disable=protected-access schedule._WriteArchiveString(archive, 'feed_info.txt', feed_info_string)