-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n #5
Comments
I think that this is more of a specification of the whole project rather than an issue, @NicolasLiampotis. |
@stevelaskaridis I agree i18n support cannot be closed by a single PR. It is however a feature (issue label updated) that can be closed once certain things are in place, e.g., Ruby I18n gem is configured, model classes/database schema are locale-aware, portal content is localised. Feel free to break it down into smaller tasks that can be linked to commits/PRs. |
Allow me to disagree with you on this. Let me draw a parallel for you. It's like closing an issue saying that an API should be RESTful. Of course, it can be at a certain point, but additions and changes to the codebase may bring up the same issue again and again. |
When you make additions and changes to the codebase you should generally not break closed issues. So in your example, you would create a new issue in case of an API update and make sure that the API stays RESTful after resolving the new issue. As I said, breaking i18n support into smaller issues/tasks might be useful - it is up to you. |
So, it's laying the foundations for I18n Internationalization (which is an issue that can be closed). |
@stevelaskaridis: Feel free to do any refactoring necessary. I tried to base the current description on the i18n definition from W3C: |
Add nodejs to Ruby Docker image
Enable easy localisation for the portal with initial support for Greek and English.
Localisable elements should be separated from the source code so that localised alternatives can be loaded or selected based on the user's preferences as needed. Localisable elements include:
The text was updated successfully, but these errors were encountered: