Support cmd key for macOS

[moeenio]

Would be great that the keyboard shortcut to open the find menu would work with the ⌘ (Command) key on macOS.

[PortPixel]

@griffpatch would be a one line change
inject3.js line 798
if (document.URL.indexOf('editor') > 0 && e.key === 'f' && e.ctrlKey) {
to
if (document.URL.indexOf('editor') > 0 && e.key === 'f' && (e.ctrlKey || e.metaKey)) {

This may also trigger on windows key + f on windows machines, I don't have one to test on.

[AmazingMech2418]

@PortPixel @griffpatch The windows + f could also be eliminated using navigator.platform, given that that is allowed in chrome extensions. I haven't done much with chrome extensions, so I'm not completely sure if that would work, but I think it should.

[scratchusernamemrtbts]

@griffpatch please can you support macos key because the middle click doesn't mave on mac mouse and i can't use command+f or command+space to use something

[griffpatch]

Really :/ I thought the meta key was the max special key... I hoped that what I had coded would work.

…

On Sun, 12 Jul 2020, 09:14 meepooh, ***@***.***> wrote: @griffpatch <https://github.com/griffpatch> please can you support macos key because the middle click doesn't mave on mac mouse and i can't use command+f or command+space to use something — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABTM3PWSL4ZU7KQ4UJIRQ7TR3FWG7ANCNFSM4KZC26EA> .

[PortPixel]

@griffpatch Works for me
MacOS 10.15.4 (19E287)

@scratchusernamemrtbts maybe you need to update the extension?

[scratchusernamemrtbts]

@griffpatch Works for me
MacOS 10.15.4 (19E287)

@scratchusernamemrtbts maybe you need to update the extension?

thanks

[Explosion-Scratch]

@scratchusernamemrtbts Actually, Command+M minimizes the current window, the equivalent of clicking the yellow "-" symbol at the top left corner of most windows.
As for the original suggestion, in my opinion Control-space works fine for me. =/

[scratchusernamemrtbts]

@scratchusernamemrtbts Actually, Command+M minimizes the current window, the equivalent of clicking the yellow "-" symbol at the top left corner of most windows.
As for the original suggestion, in my opinion Control-space works fine for me. =/

Oh I forgot.

[scratchusernamemrtbts]

@griffpatch Works for me
MacOS 10.15.4 (19E287)
@scratchusernamemrtbts maybe you need to update the extension?

thanks
EDIT: it works but when i press cmd+space it open the macos spot light search maybe you could add another key like cmd+d I’m not sure they already have this shortcut in macOS I’m replying from iPad

i solve it already by changing the spotlight search hotkey to shift+cmd+space

[Explosion-Scratch]

@scratchusermrtbts Command and D bookmarks the current browser page on Mac.

[scratchusernamemrtbts]

@scratchusermrtbts Command and D bookmarks the current browser page on Mac.

i solve it now here

[scratchusernamemrtbts]

now there is onne thing i still can't use

my apple mouse don't have a middle click button can you add the cmd+space and ctrl+space for this feature too?

Or you can just make this menu bar

[moeenio]

my apple mouse don't have a middle click button

Try three-finger tap? Or pinching the sides of the mouse?

[scratchusernamemrtbts]

my apple mouse don't have a middle click button

Try three-finger tap? Or pinching the sides of the mouse?

Ok I'll try.
But how do you pinch the side of the mouse

[Explosion-Scratch]

I also don't have middled click. I just use the built in trackpad on my mac.

[moeenio]

You can have middle click with three thingers on a trackpad with an app called MiddleClick :)

[scratchusernamemrtbts]

I also don't have middled click. I just use the built in trackpad on my mac.

I use an iMac so I don't have a trackpad