Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDA TOTAL_READS confusion #8

Open
evelyn-schmidt opened this issue Nov 2, 2023 · 0 comments
Open

FDA TOTAL_READS confusion #8

evelyn-schmidt opened this issue Nov 2, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@evelyn-schmidt
Copy link
Collaborator

Kelsy noticed that there seems to be some incorrect values in the FDA quality threshold report. The TOTAL_READS for both tumor DNA, normal DNA, and RNA was extremely low and prompted suspicion as to why that number was so low. The number comes from the unaligned_metrics1.txt and is the total reads for only one read fastq. The fda metrics script pulls the number from the unaligned_tumor_table. In the other fda metrics files, the label total reads is the combined read1 and read2 number of reads. So initially this value in the FDA metrics report is misleading and appears to be incorrect. However, @malachig clarified that the TOTAL_READS should indeed be the total reads for one read file.

JLF-100-053
  • I suggest renaming TOTAL_READS to be something more clear so this confusion does not happen in the future
    • maybe TOTAL_READS_R1
  • I also suggest adding the file paths to scripts/fda_quality_thresholds.csv so that it is clear where thes values are being pulled from
  • Finally, I think t would be helpful if the qc report has the evaluation label on the metrics so one did not have to references the neoantigen design doc when writing the final report
Screenshot 2023-11-02 at 11 28 43 AM
@evelyn-schmidt evelyn-schmidt added the enhancement New feature or request label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant