Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in SchurComplementSolvers.jl #41

Open
oriolcg opened this issue Oct 4, 2023 · 1 comment
Open

Error in SchurComplementSolvers.jl #41

oriolcg opened this issue Oct 4, 2023 · 1 comment
Assignees

Comments

@oriolcg
Copy link
Member

oriolcg commented Oct 4, 2023

I think there is an error in this line:

copy!(bp,y_p); mul!(bp,C,du,1.0,-1.0) # bp = C*(A^-1 y_u) - y_p

To my understanding it should be something like:

copy!(bp,y_p); mul!(bp,C,x_u,-1.0,1.0)  # bp  = y_p - C*(A^-1 y_u)

I was having wrong results in my application and this modification gives the good solution.

@JordiManyer
Copy link
Member

Yes, that looks like a bug. I'll have a look. In any case that solver is due a rather big revision soon.

@JordiManyer JordiManyer self-assigned this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants