Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠️ Refactor: Add Pre-Commit Hooks to enforce code quality #47

Open
ArsalaBangash opened this issue Oct 20, 2020 · 0 comments
Open

🛠️ Refactor: Add Pre-Commit Hooks to enforce code quality #47

ArsalaBangash opened this issue Oct 20, 2020 · 0 comments
Labels
Domain: Dev Experience This issue pertains to a developer's emotions and attitudes when building Grey Software. hacktoberfest-accepted Role: Software Engineer Uses technology to design, develop, test, and maintain creative software solutions. Type: Maintenance An issue that make things clearer or removes ambiguity without changing base functionality.

Comments

@ArsalaBangash
Copy link
Member

Motivation 🏁

We want to help devs ensure consistent code quality by running a process to fix code quality issues upon every commit to the repo.

Describe your refactoring solution 🛠️

I propose adding pre-commit hooks via husky and lint-stages in a similar manner to our org repo: https://github.com/grey-software/org/blob/master/package.json

This issue depends on grey-software/Material-Math#65 because it requires the styling configuration files to be present
@ArsalaBangash ArsalaBangash added Domain: Dev Experience This issue pertains to a developer's emotions and attitudes when building Grey Software. Type: Maintenance An issue that make things clearer or removes ambiguity without changing base functionality. Role: Software Engineer Uses technology to design, develop, test, and maintain creative software solutions. hacktoberfest-accepted labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Domain: Dev Experience This issue pertains to a developer's emotions and attitudes when building Grey Software. hacktoberfest-accepted Role: Software Engineer Uses technology to design, develop, test, and maintain creative software solutions. Type: Maintenance An issue that make things clearer or removes ambiguity without changing base functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ArsalaBangash