From 69d82f11850f71f841d45277d1fc06bb0ae91abd Mon Sep 17 00:00:00 2001 From: njtierney Date: Fri, 10 Jan 2025 14:11:25 +1100 Subject: [PATCH 1/2] improve how we print dimensions when using pretty dim - e.g., if you already pass it a dimension. --- R/utils.R | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/R/utils.R b/R/utils.R index 34b92ab8..1b730f64 100644 --- a/R/utils.R +++ b/R/utils.R @@ -1165,7 +1165,13 @@ outside_version_range <- function(provided, range) { outside_range } -pretty_dim <- function(x) paste0(dim(x), collapse = "x") +pretty_dim <- function(x){ + x_dim <- dim(x) + print_dim_x <- x_dim %||% x + + prettied_dim <- paste0(print_dim_x, collapse = "x") + prettied_dim +} are_initials <- function(x){ vapply( From e38654df9bbd22a6b9b5d1e6ba7c7f32075be468 Mon Sep 17 00:00:00 2001 From: njtierney Date: Tue, 14 Jan 2025 12:20:24 +1100 Subject: [PATCH 2/2] fix warning for vignette index not matching title --- vignettes/installation.Rmd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vignettes/installation.Rmd b/vignettes/installation.Rmd index 67ed4d5f..b3c4f233 100644 --- a/vignettes/installation.Rmd +++ b/vignettes/installation.Rmd @@ -2,7 +2,7 @@ title: "Installing Dependencies" output: rmarkdown::html_vignette vignette: > - %\VignetteIndexEntry{installation} + %\VignetteIndexEntry{Installing Dependencies} %\VignetteEngine{knitr::rmarkdown} %\VignetteEncoding{UTF-8} ---