Skip to content

Commit c44f75b

Browse files
committed
Ensure suggested versions are just one value
1 parent 1fca91a commit c44f75b

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

R/install_greta_deps.R

+4-5
Original file line numberDiff line numberDiff line change
@@ -227,10 +227,10 @@ greta_python_deps <- function(tf_version = "2.15.0",
227227
class = c("greta_python_deps", "data.frame")
228228
)
229229

230+
# check for envvar to silence these checks
230231
check_tfp_tf_semantic(deps_obj)
231232
check_greta_tf_range(deps_obj)
232233
check_greta_tfp_range(deps_obj)
233-
234234
check_greta_python_range(deps_obj$python_version)
235235
check_greta_deps_config(deps_obj)
236236

@@ -379,7 +379,6 @@ check_greta_python_range <- function(version_provided,
379379
check_greta_deps_config <- function(python_deps,
380380
call = rlang::caller_env()){
381381

382-
# check for envvar to silence these checks
383382
check_greta_python_deps(python_deps)
384383

385384
python_deps <- python_deps |>
@@ -462,9 +461,9 @@ check_greta_deps_config <- function(python_deps,
462461
"suggest_py" = py_matches
463462
)
464463

465-
suggested_tfp <- as.character(suggested_match$tfp_version)
466-
suggested_tf <- as.character(suggested_match$tf_version)
467-
suggested_py <- as.character(suggested_match$python_version_max)
464+
suggested_tfp <- as.character(max(suggested_match$tfp_version))
465+
suggested_tf <- as.character(max(suggested_match$tf_version))
466+
suggested_py <- as.character(max(suggested_match$python_version_max))
468467

469468
cli::cli_abort(
470469
message = c("Provided {.code greta_python_deps} does not match valid \\

0 commit comments

Comments
 (0)