Use $(AndroidPackVersion) to get XA version

Xamarin.Android's native runtime logs a handful of version information
on application startup.  This information includes XA version, up until
now represented by the `$(ProductVersion)` MSBuild property.  However,
the property hasn't been updated for quite a while, with Xamarin.Android
having switched to `$(AndroidPackVersion)` instead.

Modify xaprepare to use `$(AndroidPackVersion)` instead of
`$(ProductVersion)` so that we log the correct version at application
startup.

Author: grendello

build-tools/xaprepare/xaprepare/Application/KnownProperties.cs

@@ -12,6 +12,8 @@ static class KnownProperties
 		public const string AndroidLatestStableFrameworkVersion = "AndroidLatestStableFrameworkVersion";
 		public const string AndroidMxeFullPath                  = "AndroidMxeFullPath";
 		public const string AndroidNdkDirectory                 = "AndroidNdkDirectory";
+		public const string AndroidPackVersion                  = "AndroidPackVersion";
+		public const string AndroidPackVersionSuffix            = "AndroidPackVersionSuffix";
 		public const string AndroidSdkDirectory                 = "AndroidSdkDirectory";
 		public const string AndroidSupportedHostJitAbis         = "AndroidSupportedHostJitAbis";
 		public const string AndroidSupportedTargetAotAbis       = "AndroidSupportedTargetAotAbis";

build-tools/xaprepare/xaprepare/Application/Properties.Defaults.cs.in

@@ -16,6 +16,8 @@ namespace Xamarin.Android.Prepare
 			properties.Add (KnownProperties.AndroidLatestStableFrameworkVersion, StripQuotes ("@AndroidLatestStableFrameworkVersion@"));
 			properties.Add (KnownProperties.AndroidMxeFullPath,                  StripQuotes (@"@AndroidMxeFullPath@"));
 			properties.Add (KnownProperties.AndroidNdkDirectory,                 StripQuotes (@"@AndroidNdkDirectory@"));
+			properties.Add (KnownProperties.AndroidPackVersion,                  StripQuotes (@"@AndroidPackVersion@"));
+			properties.Add (KnownProperties.AndroidPackVersionSuffix,            StripQuotes (@"@AndroidPackVersionSuffix@"));
 			properties.Add (KnownProperties.AndroidSdkDirectory,                 StripQuotes (@"@AndroidSdkDirectory@"));
 			properties.Add (KnownProperties.AndroidSupportedHostJitAbis,         StripQuotes ("@AndroidSupportedHostJitAbis@"));
 			properties.Add (KnownProperties.AndroidSupportedTargetAotAbis,       StripQuotes ("@AndroidSupportedTargetAotAbis@"));

build-tools/xaprepare/xaprepare/Steps/Step_GenerateFiles.cs

@@ -165,6 +165,12 @@ GeneratedFile Get_XABuildConfig_cs (Context context)
 		{
 			const string OutputFileName = "XABuildConfig.cs";
 
+			string xaVersion = context.Properties.GetRequiredValue (KnownProperties.AndroidPackVersion);
+			string? xaVersionSuffix = context.Properties.GetRequiredValue (KnownProperties.AndroidPackVersionSuffix);
+			if (!String.IsNullOrEmpty(xaVersionSuffix)) {
+				xaVersion = $"{xaVersion}-{xaVersionSuffix}";
+			}
+
 			var replacements = new Dictionary<string, string> (StringComparer.Ordinal) {
 				{ "@NDK_REVISION@",              context.BuildInfo.NDKRevision },
 				{ "@NDK_RELEASE@",               BuildAndroidPlatforms.AndroidNdkVersion },
@@ -180,7 +186,7 @@ GeneratedFile Get_XABuildConfig_cs (Context context)
 				{ "@ANDROID_DEFAULT_TARGET_DOTNET_API_LEVEL@", context.Properties.GetRequiredValue (KnownProperties.AndroidDefaultTargetDotnetApiLevel) },
 				{ "@ANDROID_LATEST_STABLE_API_LEVEL@", context.Properties.GetRequiredValue (KnownProperties.AndroidLatestStableApiLevel) },
 				{ "@ANDROID_LATEST_UNSTABLE_API_LEVEL@", context.Properties.GetRequiredValue (KnownProperties.AndroidLatestUnstableApiLevel) },
-				{ "@XAMARIN_ANDROID_VERSION@",   context.Properties.GetRequiredValue (KnownProperties.ProductVersion) },
+				{ "@XAMARIN_ANDROID_VERSION@",   xaVersion },
 				{ "@XAMARIN_ANDROID_COMMIT_HASH@", context.BuildInfo.XACommitHash },
 				{ "@XAMARIN_ANDROID_BRANCH@", context.BuildInfo.XABranch },
 			};

build-tools/xaprepare/xaprepare/xaprepare.targets

@@ -50,6 +50,8 @@
       <Replacement Include="@AndroidMxeFullPath@=$(AndroidMxeFullPath)" />
       <Replacement Include="@AndroidNdkDirectory@=$(AndroidNdkDirectory)" />
       <Replacement Include="@AndroidNdkVersion@=$(AndroidNdkVersion)" />
+      <Replacement Include="@AndroidPackVersion@=$(AndroidPackVersion)" />
+      <Replacement Include="@AndroidPackVersionSuffix@=$(AndroidPackVersionSuffix)" />
       <Replacement Include="@AndroidSdkDirectory@=$(AndroidSdkDirectory)" />
       <Replacement Include="@AndroidSupportedHostJitAbis@=$(AndroidSupportedHostJitAbis)" />
       <Replacement Include="@AndroidSupportedTargetAotAbis@=$(AndroidSupportedTargetAotAbis)" />