Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature suggestion: work with time travel #4

Open
mheiber opened this issue Sep 6, 2016 · 3 comments
Open

Feature suggestion: work with time travel #4

mheiber opened this issue Sep 6, 2016 · 3 comments

Comments

@mheiber
Copy link

mheiber commented Sep 6, 2016

Nice simple library!
If I understand correctly, redux-side-effect (like redux-saga, redux-loop, etc) doesn't currently work well with time travel, since replaying actions also re-calls functions that cause side effects. Is that right?

I think there's a good solution, but want to check with you to see if this is a problem first.

@gregwebs
Copy link
Owner

gregwebs commented Sep 6, 2016

I think you can make it work with time travel by having a few special rules

@mheiber
Copy link
Author

mheiber commented Sep 6, 2016

@gregwebs what do you mean? Thanks for your help as I try to figure this out.

@gregwebs
Copy link
Owner

I think you need to change the code to recognize when you are in development and doing time travelling. You could for example cache the original response from the side effect and not actually invoke the side effect function the next time around but just use the cached response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@gregwebs @mheiber and others