Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release with Rails 7.1+ support #168

Closed
mpvosseller opened this issue Jul 3, 2024 · 4 comments
Closed

Release with Rails 7.1+ support #168

mpvosseller opened this issue Jul 3, 2024 · 4 comments

Comments

@mpvosseller
Copy link

mpvosseller commented Jul 3, 2024

Can you release a version with support for Rails 7.1. The latest commit (5dd3177) at the time of this writing appears to work for me.

Background:

After upgrading to Rails 7.1 I got the below error when using the f.select_recurring form helper:

undefined method `options_for_select' for #<RecurringSelectHelper::RecurringSelectTag

After debugging it seems the problem is that ActionView::Helpers::FormOptionsHelper is not included in RecurringSelectHelper::RecurringSelectTag for some reason.

I tested the latest commit on main (5dd3177) and that seems to work. I assume something in or after #166 fixed it.

Thanks!

@joshRpowell
Copy link

@gregschmit given Rails 7.2 was released last week, can we tag and release the 7.1 support?

Would be glad to assist, if needed

Thanks for all your work on this helpful Gem!

@adamavenord
Copy link

I just updated gem to fix this issue.
It works for Rails 7.1+
You can find that in here.

@gregschmit
Copy link
Owner

There was a major refactoring merged so I pushed out a new gem version 4.0.0.rc1 so if there are any fixes that need to happen, they can be released on 4.0.0: https://rubygems.org/gems/recurring_select/versions/4.0.0.rc1

Thank you everyone for bugging me about this.

@msxavi
Copy link

msxavi commented Oct 1, 2024

4.0.0.rc1 seems to be working on Rails 7.1 so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants