Fix SimpleMenuPreference for support lib v28.0.0-alpha3

[gregkorossy]

The SimpleMenuPreference uses some extra elements to simulate the reserved icon space, however, from alpha3 the default value of reserving icon space is set to true but the preference ignores it.

[Mygod]

I mentioned the fix in my comment in another issue.

[gregkorossy]

Which one?

[gregkorossy]

Fixed in meanwhile by using Preference.Material as the parent of Preference.SimpleMenuPreference.

[Mygod]

#111 (comment)

[Mygod]

More precisely just put this in styles.xml: https://github.com/shadowsocks/shadowsocks-android/blob/8aabc73b9698b2bb26a89717d59ac1660e79fad8/mobile/src/main/res/values/styles.xml#L18-L25

[gregkorossy]

I think it's better to use the Preference.Material as the parent style since if the devs change it, they will be automatically propagated instead of manually copying the changed attributes.

[Mygod]

According to decompiled source in alpha 1 this is how other preferences do it, but maybe they have changed it.

[gregkorossy]

Yes, they do it like that, but if they change an attribute in alpha4 (or whatever the next release will be), you have to copy them over instead of just using the changed attributes directly.

[gregkorossy]

Released v28.0.0.0-alpha3. It fixes this problem.

[ln-12]

Hey guys, sorry that I have to ask another question on this topic. I am currently using version 28.0.0.0-alpha3. Setting isIconSpaceReserved = false works just fine for settings, but not for categories.
Example: Relating to the upper picture, "RingtonePreference" is aligned left but "Dynamic category" is aligned as isIconSpaceReserved was set to true (with extra spacing on the left). Do you have an idea what I'm doing wrong?

Btw: Awesome library!

[gregkorossy]

See #132 for details. This is a bug in the official lib, and this lib only has the fix in the AndroidX version (for the time being at least).

[ln-12]

Thanks a lot, I'll try it out.