Skip to content

Commit 6ba3172

Browse files
tehcasterakpm00
authored andcommitted
get_maintainer: stop reporting subsystem status as maintainer role
After introducing the --substatus option, we can stop adjusting the reported maintainer role by the subsystem's status. For compatibility with the --git-chief-penguins option, keep the "chief penguin" role. Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Vlastimil Babka <[email protected]> Reviewed-by: Lorenzo Stoakes <[email protected]> Tested-by: Lorenzo Stoakes <[email protected]> Cc: Bryan O'Donoghue <[email protected]> Cc: Joe Perches <[email protected]> Cc: Kees Cook <[email protected]> Cc: Ted Ts'o <[email protected]> Cc: Thorsten Leemhuis <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent 9ad18c8 commit 6ba3172

File tree

1 file changed

+6
-15
lines changed

1 file changed

+6
-15
lines changed

Diff for: scripts/get_maintainer.pl

+6-15
Original file line numberDiff line numberDiff line change
@@ -1084,7 +1084,7 @@ sub usage {
10841084
--moderated => include moderated lists(s) if any (default: true)
10851085
--s => include subscriber only list(s) if any (default: false)
10861086
--remove-duplicates => minimize duplicate email names/addresses
1087-
--roles => show roles (status:subsystem, git-signer, list, etc...)
1087+
--roles => show roles (role:subsystem, git-signer, list, etc...)
10881088
--rolestats => show roles and statistics (commits/total_commits, %)
10891089
--substatus => show subsystem status if not Maintained (default: match --roles when output is tty)"
10901090
--file-emails => add email addresses found in -f file (default: 0 (off))
@@ -1298,32 +1298,23 @@ sub get_maintainer_role {
12981298
my $start = find_starting_index($index);
12991299
my $end = find_ending_index($index);
13001300

1301-
my $role = "unknown";
1301+
my $role = "maintainer";
13021302
my $subsystem = get_subsystem_name($index);
1303+
my $status = "unknown";
13031304

13041305
for ($i = $start + 1; $i < $end; $i++) {
13051306
my $tv = $typevalue[$i];
13061307
if ($tv =~ m/^([A-Z]):\s*(.*)/) {
13071308
my $ptype = $1;
13081309
my $pvalue = $2;
13091310
if ($ptype eq "S") {
1310-
$role = $pvalue;
1311+
$status = $pvalue;
13111312
}
13121313
}
13131314
}
13141315

1315-
$role = lc($role);
1316-
if ($role eq "supported") {
1317-
$role = "supporter";
1318-
} elsif ($role eq "maintained") {
1319-
$role = "maintainer";
1320-
} elsif ($role eq "odd fixes") {
1321-
$role = "odd fixer";
1322-
} elsif ($role eq "orphan") {
1323-
$role = "orphan minder";
1324-
} elsif ($role eq "obsolete") {
1325-
$role = "obsolete minder";
1326-
} elsif ($role eq "buried alive in reporters") {
1316+
$status = lc($status);
1317+
if ($status eq "buried alive in reporters") {
13271318
$role = "chief penguin";
13281319
}
13291320

0 commit comments

Comments
 (0)