Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate title from subtitle in config show-text #160

Closed
1 task done
vincerubinetti opened this issue Feb 28, 2023 · 1 comment · Fixed by #174
Closed
1 task done

Separate title from subtitle in config show-text #160

vincerubinetti opened this issue Feb 28, 2023 · 1 comment · Fixed by #174
Labels
enhancement New feature or request

Comments

@vincerubinetti
Copy link
Collaborator

Checks

Link to your website repo

No response

Version of Lab Website Template you are using

1.0.0

Description

The Pividori lab has a logo image with their title, but not their subtitle. _config.yaml has a logo-text flag that hides both the title and subtitle next to the logo, but sometimes a user might want to hide either or.

Very easy to add. Naming the params is the hardest part. logo-title/subtitle? How will someone interpret that flag, "does my logo have a title/subtitle" or "should we show a title/subtitle next to the logo"? show-title/subtitle? Maybe. They might expect setting it to false to hide it everywhere -- in the tab name and meta tags, not just the header -- when it won't.

@vincerubinetti vincerubinetti added the enhancement New feature or request label Feb 28, 2023
@miltondp
Copy link
Member

miltondp commented Mar 1, 2023

Maybe an option could be logo-has-title (and logo-has-subtitle). By default they are false, so the title/subtitle are shown (not shown otherwise).

@vincerubinetti vincerubinetti linked a pull request Mar 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants