Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async loaders #8

Open
Kwieeciol opened this issue Mar 7, 2023 · 1 comment
Open

Async loaders #8

Kwieeciol opened this issue Mar 7, 2023 · 1 comment

Comments

@Kwieeciol
Copy link

I cannot understand the design of this library at all, it's for quart which is an async library, so why the loaders functions cannot be async? I'm trying to make a database call inside user_claims_loader to get some data based on the identity and encrypt it into the JWT.

It seems like the library is just flast-jwt-extended but with very few extra features and occasionally an async function... The create_access_token function should also be async, since encryption is CPU heavy, could just throw it into a thread and wait for it instead of blocking the event loop. Please explain the reasoning for using so few async functions and not a lot of support for them.

Thank you, have a nice day.

@Kwieeciol
Copy link
Author

Any updates on this? It's been 8 months and not even a reply...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant