Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modeID: add glitches to the models #142

Open
grd349 opened this issue Jul 25, 2019 · 2 comments
Open

modeID: add glitches to the models #142

grd349 opened this issue Jul 25, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@grd349
Copy link
Owner

grd349 commented Jul 25, 2019

Some stars are showing such strong glitch signatures that it makes sense to consider adding glitches into asy_peakbag.

We know how to do this, but will need to generate some prior data. We can probably use the Vrard results in the first instance to get things setup.

@grd349 grd349 added the enhancement New feature or request label Jul 25, 2019
@grd349 grd349 added this to the Version 2.0 milestone Jul 25, 2019
@ojhall94
Copy link
Collaborator

I'd love to help implement this, I'd like some glitch knowledge.

@ojhall94 ojhall94 self-assigned this Jul 25, 2019
@grd349
Copy link
Owner Author

grd349 commented Jul 25, 2019

All the info is in https://arxiv.org/abs/1505.07280 :) . It includes some relations that we can use as a starting prior.

We would probably add an exponential decay on top of the glitch sinusoid.

The work plan would be something like:

Implement the extra parameters and the extra term in the model in asy_peakbag.
Add a prior based on Vrard on the new parameters.
Run on lots of stars.
Use the results of the last step to build a new epsilon prior that now includes the glitch properties.
Remove the Vrard prior.
Run lots of tests.
Merge.

We can discuss offline and then we can add a summary here.

@nielsenmb nielsenmb changed the title Asy_peakbag: add glitches to the model modeID: add glitches to the models Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants