Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forgetting to register the Service Provider does not trigger any error #9

Open
clarkwinkelmann opened this issue May 12, 2017 · 0 comments

Comments

@clarkwinkelmann
Copy link
Member

If we use the package but do not register the Service Provider, it's not immediately obvious why requests do not work as expected.

Because Gravure\Api\Http\Request is resolved by the IOC as a new blank query, none of the actual parameters are passed back to it, in particular pagination and include parameters.

The package should probably throw an error if the Request object it receives did not come through the expected Container Binding from the Service Provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant