-
Notifications
You must be signed in to change notification settings - Fork 1.8k
/
Copy pathgrpcserver_test.go
4765 lines (4252 loc) · 150 KB
/
grpcserver_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
/*
* Teleport
* Copyright (C) 2023 Gravitational, Inc.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
package auth
import (
"context"
"crypto/tls"
"crypto/x509"
"crypto/x509/pkix"
"encoding/base32"
"encoding/pem"
"fmt"
"net"
"net/http"
"net/http/httptest"
"sort"
"testing"
"time"
"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
"github.com/google/uuid"
"github.com/gravitational/trace"
"github.com/gravitational/trace/trail"
"github.com/jonboulle/clockwork"
"github.com/pquerna/otp"
"github.com/pquerna/otp/totp"
prom_client_model "github.com/prometheus/client_model/go"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
otlpcommonv1 "go.opentelemetry.io/proto/otlp/common/v1"
otlpresourcev1 "go.opentelemetry.io/proto/otlp/resource/v1"
otlptracev1 "go.opentelemetry.io/proto/otlp/trace/v1"
"google.golang.org/protobuf/testing/protocmp"
"google.golang.org/protobuf/types/known/emptypb"
"github.com/gravitational/teleport"
"github.com/gravitational/teleport/api/client/proto"
"github.com/gravitational/teleport/api/constants"
apidefaults "github.com/gravitational/teleport/api/defaults"
clusterconfigpb "github.com/gravitational/teleport/api/gen/proto/go/teleport/clusterconfig/v1"
mfav1 "github.com/gravitational/teleport/api/gen/proto/go/teleport/mfa/v1"
"github.com/gravitational/teleport/api/internalutils/stream"
"github.com/gravitational/teleport/api/mfa"
"github.com/gravitational/teleport/api/observability/tracing"
"github.com/gravitational/teleport/api/types"
"github.com/gravitational/teleport/api/types/installers"
"github.com/gravitational/teleport/api/utils"
"github.com/gravitational/teleport/api/utils/keys"
"github.com/gravitational/teleport/api/utils/sshutils"
"github.com/gravitational/teleport/entitlements"
"github.com/gravitational/teleport/lib/auth/authclient"
"github.com/gravitational/teleport/lib/auth/mocku2f"
"github.com/gravitational/teleport/lib/auth/testauthority"
wantypes "github.com/gravitational/teleport/lib/auth/webauthntypes"
"github.com/gravitational/teleport/lib/authz"
"github.com/gravitational/teleport/lib/cryptosuites"
"github.com/gravitational/teleport/lib/defaults"
dtauthz "github.com/gravitational/teleport/lib/devicetrust/authz"
"github.com/gravitational/teleport/lib/modules"
"github.com/gravitational/teleport/lib/services"
"github.com/gravitational/teleport/lib/session"
"github.com/gravitational/teleport/lib/srv/server/installer"
"github.com/gravitational/teleport/lib/tlsca"
)
func TestMFADeviceManagement(t *testing.T) {
testServer := newTestTLSServer(t)
authServer := testServer.Auth()
clock := testServer.Clock().(clockwork.FakeClock)
ctx := context.Background()
// Enable MFA support.
authPref, err := types.NewAuthPreference(types.AuthPreferenceSpecV2{
Type: constants.Local,
SecondFactors: []types.SecondFactorType{
types.SecondFactorType_SECOND_FACTOR_TYPE_OTP,
types.SecondFactorType_SECOND_FACTOR_TYPE_WEBAUTHN,
types.SecondFactorType_SECOND_FACTOR_TYPE_SSO,
},
Webauthn: &types.Webauthn{
RPID: "localhost",
},
})
const webOrigin = "https://localhost" // matches RPID above
require.NoError(t, err)
_, err = authServer.UpsertAuthPreference(ctx, authPref)
require.NoError(t, err)
// Create a fake user.
user, _, err := CreateUserAndRole(authServer, "mfa-user", []string{"role"}, nil)
require.NoError(t, err)
userClient, err := testServer.NewClient(TestUser(user.GetName()))
require.NoError(t, err)
// No MFA devices should exist for a new user.
resp, err := userClient.GetMFADevices(ctx, &proto.GetMFADevicesRequest{})
require.NoError(t, err)
require.Empty(t, resp.Devices)
// Add one device of each kind
devs := addOneOfEachMFADevice(t, userClient, clock, webOrigin)
// Run scenarios beyond adding one of each device, both happy and failures.
webKey2, err := mocku2f.Create()
require.NoError(t, err)
webKey2.PreferRPID = true
const webDev2Name = "webauthn2"
const pwdlessDevName = "pwdless"
addTests := []struct {
desc string
opts mfaAddTestOpts
}{
{
desc: "fail TOTP auth challenge",
opts: mfaAddTestOpts{
deviceName: "fail-dev",
deviceType: proto.DeviceType_DEVICE_TYPE_WEBAUTHN,
authHandler: func(t *testing.T, req *proto.MFAAuthenticateChallenge) *proto.MFAAuthenticateResponse {
require.NotNil(t, req.TOTP)
// Respond to challenge using an unregistered TOTP device,
// which should fail the auth challenge.
badDev, err := totp.Generate(totp.GenerateOpts{Issuer: "Teleport", AccountName: user.GetName()})
require.NoError(t, err)
code, err := totp.GenerateCode(badDev.Secret(), clock.Now())
require.NoError(t, err)
return &proto.MFAAuthenticateResponse{Response: &proto.MFAAuthenticateResponse_TOTP{TOTP: &proto.TOTPResponse{
Code: code,
}}}
},
checkAuthErr: require.Error,
},
},
{
desc: "fail a TOTP registration challenge",
opts: mfaAddTestOpts{
deviceName: "fail-dev",
deviceType: proto.DeviceType_DEVICE_TYPE_TOTP,
authHandler: devs.totpAuthHandler,
checkAuthErr: require.NoError,
registerHandler: func(t *testing.T, req *proto.MFARegisterChallenge) *proto.MFARegisterResponse {
totpRegisterChallenge := req.GetTOTP()
require.NotEmpty(t, totpRegisterChallenge)
require.Equal(t, totpRegisterChallenge.Algorithm, otp.AlgorithmSHA1.String())
// Use the wrong secret for registration, causing server
// validation to fail.
code, err := totp.GenerateCodeCustom(base32.StdEncoding.EncodeToString([]byte("wrong-secret")), clock.Now(), totp.ValidateOpts{
Period: uint(totpRegisterChallenge.PeriodSeconds),
Digits: otp.Digits(totpRegisterChallenge.Digits),
Algorithm: otp.AlgorithmSHA1,
})
require.NoError(t, err)
return &proto.MFARegisterResponse{
Response: &proto.MFARegisterResponse_TOTP{TOTP: &proto.TOTPRegisterResponse{
Code: code,
}},
}
},
checkRegisterErr: require.Error,
},
},
{
desc: "add a second webauthn device",
opts: mfaAddTestOpts{
deviceName: webDev2Name,
deviceType: proto.DeviceType_DEVICE_TYPE_WEBAUTHN,
authHandler: devs.webAuthHandler,
checkAuthErr: require.NoError,
registerHandler: func(t *testing.T, challenge *proto.MFARegisterChallenge) *proto.MFARegisterResponse {
ccr, err := webKey2.SignCredentialCreation(webOrigin, wantypes.CredentialCreationFromProto(challenge.GetWebauthn()))
require.NoError(t, err)
return &proto.MFARegisterResponse{
Response: &proto.MFARegisterResponse_Webauthn{
Webauthn: wantypes.CredentialCreationResponseToProto(ccr),
},
}
},
checkRegisterErr: require.NoError,
},
},
{
desc: "fail a webauthn auth challenge",
opts: mfaAddTestOpts{
deviceName: "webauthn-1512000",
deviceType: proto.DeviceType_DEVICE_TYPE_WEBAUTHN,
authHandler: func(t *testing.T, challenge *proto.MFAAuthenticateChallenge) *proto.MFAAuthenticateResponse {
require.NotNil(t, challenge.WebauthnChallenge) // webauthn enabled
// Sign challenge with an unknown device.
key, err := mocku2f.Create()
require.NoError(t, err)
key.PreferRPID = true
key.IgnoreAllowedCredentials = true
resp, err := key.SignAssertion(webOrigin, wantypes.CredentialAssertionFromProto(challenge.WebauthnChallenge))
require.NoError(t, err)
return &proto.MFAAuthenticateResponse{
Response: &proto.MFAAuthenticateResponse_Webauthn{
Webauthn: wantypes.CredentialAssertionResponseToProto(resp),
},
}
},
checkAuthErr: func(t require.TestingT, err error, i ...interface{}) {
require.Error(t, err)
require.True(t, trace.IsAccessDenied(err))
},
},
},
{
desc: "fail a webauthn registration challenge",
opts: mfaAddTestOpts{
deviceName: "webauthn-1512000",
deviceType: proto.DeviceType_DEVICE_TYPE_WEBAUTHN,
authHandler: devs.webAuthHandler,
checkAuthErr: require.NoError,
registerHandler: func(t *testing.T, challenge *proto.MFARegisterChallenge) *proto.MFARegisterResponse {
require.NotNil(t, challenge.GetWebauthn())
key, err := mocku2f.Create()
require.NoError(t, err)
key.PreferRPID = true
ccr, err := key.SignCredentialCreation(
"http://badorigin.com" /* origin */, wantypes.CredentialCreationFromProto(challenge.GetWebauthn()))
require.NoError(t, err)
return &proto.MFARegisterResponse{
Response: &proto.MFARegisterResponse_Webauthn{
Webauthn: wantypes.CredentialCreationResponseToProto(ccr),
},
}
},
checkRegisterErr: func(t require.TestingT, err error, i ...interface{}) {
require.Error(t, err)
require.True(t, trace.IsBadParameter(err))
},
},
},
{
desc: "add passwordless device",
opts: mfaAddTestOpts{
deviceName: pwdlessDevName,
deviceType: proto.DeviceType_DEVICE_TYPE_WEBAUTHN,
deviceUsage: proto.DeviceUsage_DEVICE_USAGE_PASSWORDLESS,
authHandler: devs.webAuthHandler,
checkAuthErr: require.NoError,
registerHandler: func(t *testing.T, challenge *proto.MFARegisterChallenge) *proto.MFARegisterResponse {
require.NotNil(t, challenge.GetWebauthn(), "WebAuthn challenge cannot be nil")
key, err := mocku2f.Create()
require.NoError(t, err)
key.PreferRPID = true
key.SetPasswordless()
ccr, err := key.SignCredentialCreation(webOrigin, wantypes.CredentialCreationFromProto(challenge.GetWebauthn()))
require.NoError(t, err)
return &proto.MFARegisterResponse{
Response: &proto.MFARegisterResponse_Webauthn{
Webauthn: wantypes.CredentialCreationResponseToProto(ccr),
},
}
},
checkRegisterErr: require.NoError,
assertRegisteredDev: func(t *testing.T, dev *types.MFADevice) {
// Do a few simple device checks - lib/auth/webauthn goes in depth.
require.NotNil(t, dev.GetWebauthn(), "WebAuthnDevice cannot be nil")
require.True(t, true, dev.GetWebauthn().ResidentKey, "ResidentKey should be set to true")
},
},
},
}
for _, test := range addTests {
t.Run(test.desc, func(t *testing.T) {
testAddMFADevice(ctx, t, userClient, test.opts)
})
}
// Register an extra device to test allow deletion of other devices and test that
// the last device cannot be deleted.
const lastDeviceName = "lastDevice"
lastDevice, err := RegisterTestDevice(ctx, userClient, lastDeviceName, proto.DeviceType_DEVICE_TYPE_WEBAUTHN, devs.WebDev)
require.NoError(t, err, "RegisterTestDevice failed")
// Also add a password so we can testing add last non-passkey MFA device. Testing the
// deletion of the last passkey is handled in TestDeletingLastPasswordlessDevice below.
err = authServer.UpsertPassword(user.GetName(), []byte("living on the edge"))
require.NoError(t, err, "UpsertPassword")
// Since this device won't be deleted, we can use it to solve webauthn
// challenges throughout the tests below.
lastDeviceWebAuthnHandler := func(t *testing.T, challenge *proto.MFAAuthenticateChallenge) *proto.MFAAuthenticateResponse {
require.NotNil(t, challenge.WebauthnChallenge, "nil Webauthn challenge")
mfaResp, err := lastDevice.SolveAuthn(challenge)
require.NoError(t, err, "SolveAuthn")
return mfaResp
}
// Check that all new devices are registered.
resp, err = userClient.GetMFADevices(ctx, &proto.GetMFADevicesRequest{})
require.NoError(t, err)
deviceNames := make([]string, 0, len(resp.Devices))
deviceIDs := make(map[string]string)
for _, dev := range resp.Devices {
deviceNames = append(deviceNames, dev.GetName())
deviceIDs[dev.GetName()] = dev.Id
}
sort.Strings(deviceNames)
require.Equal(t, []string{lastDeviceName, pwdlessDevName, devs.TOTPName, devs.WebName, webDev2Name}, deviceNames)
// Delete several of the MFA devices.
deleteTests := []struct {
desc string
opts mfaDeleteTestOpts
}{
{
desc: "fail to delete an unknown device",
opts: mfaDeleteTestOpts{
deviceName: "unknown-dev",
authHandler: lastDeviceWebAuthnHandler,
checkErr: require.Error,
},
},
{
desc: "fail a TOTP auth challenge",
opts: mfaDeleteTestOpts{
deviceName: devs.TOTPName,
authHandler: func(t *testing.T, req *proto.MFAAuthenticateChallenge) *proto.MFAAuthenticateResponse {
require.NotNil(t, req.TOTP)
// Respond to challenge using an unregistered TOTP device,
// which should fail the auth challenge.
badDev, err := totp.Generate(totp.GenerateOpts{Issuer: "Teleport", AccountName: user.GetName()})
require.NoError(t, err)
code, err := totp.GenerateCode(badDev.Secret(), clock.Now())
require.NoError(t, err)
return &proto.MFAAuthenticateResponse{Response: &proto.MFAAuthenticateResponse_TOTP{TOTP: &proto.TOTPResponse{
Code: code,
}}}
},
checkErr: require.Error,
},
},
{
desc: "fail a webauthn auth challenge",
opts: mfaDeleteTestOpts{
deviceName: devs.WebName,
authHandler: func(t *testing.T, challenge *proto.MFAAuthenticateChallenge) *proto.MFAAuthenticateResponse {
require.NotNil(t, challenge.WebauthnChallenge)
// Sign challenge with an unknown device.
key, err := mocku2f.Create()
require.NoError(t, err)
key.PreferRPID = true
key.IgnoreAllowedCredentials = true
resp, err := key.SignAssertion(webOrigin, wantypes.CredentialAssertionFromProto(challenge.WebauthnChallenge))
require.NoError(t, err)
return &proto.MFAAuthenticateResponse{
Response: &proto.MFAAuthenticateResponse_Webauthn{
Webauthn: wantypes.CredentialAssertionResponseToProto(resp),
},
}
},
checkErr: require.Error,
},
},
{
desc: "delete TOTP device by name",
opts: mfaDeleteTestOpts{
deviceName: devs.TOTPName,
authHandler: lastDeviceWebAuthnHandler,
checkErr: require.NoError,
},
},
{
desc: "delete webauthn device by name",
opts: mfaDeleteTestOpts{
deviceName: devs.WebName,
authHandler: lastDeviceWebAuthnHandler,
checkErr: require.NoError,
},
},
{
desc: "delete passwordless device by name",
opts: mfaDeleteTestOpts{
deviceName: pwdlessDevName,
authHandler: lastDeviceWebAuthnHandler,
checkErr: require.NoError,
},
},
{
desc: "delete webauthn device by ID",
opts: mfaDeleteTestOpts{
deviceName: deviceIDs[webDev2Name],
authHandler: lastDeviceWebAuthnHandler,
checkErr: require.NoError,
},
},
{
desc: "fail to delete last device",
opts: mfaDeleteTestOpts{
deviceName: lastDeviceName,
authHandler: lastDeviceWebAuthnHandler,
checkErr: func(t require.TestingT, err error, _ ...any) {
require.ErrorContains(t,
err,
"cannot delete the last MFA device for this user",
"Unexpected error deleting last MFA device",
)
},
},
},
}
for _, test := range deleteTests {
t.Run(test.desc, func(t *testing.T) {
testDeleteMFADevice(ctx, t, userClient, test.opts)
})
}
// Check no remaining devices, apart from the additional device that we can't delete.
resp, err = userClient.GetMFADevices(ctx, &proto.GetMFADevicesRequest{})
require.NoError(t, err)
require.Equal(t, lastDeviceName, resp.Devices[0].GetName())
}
func TestMFADeviceManagement_SSO(t *testing.T) {
testServer := newTestTLSServer(t)
authServer := testServer.Auth()
ctx := context.Background()
// Enable MFA support.
authPref, err := types.NewAuthPreference(types.AuthPreferenceSpecV2{
Type: constants.Local,
SecondFactors: []types.SecondFactorType{
types.SecondFactorType_SECOND_FACTOR_TYPE_OTP,
types.SecondFactorType_SECOND_FACTOR_TYPE_WEBAUTHN,
types.SecondFactorType_SECOND_FACTOR_TYPE_SSO,
},
Webauthn: &types.Webauthn{
RPID: "localhost",
},
})
require.NoError(t, err)
_, err = authServer.UpsertAuthPreference(ctx, authPref)
require.NoError(t, err)
// Create a fake user.
user, _, err := CreateUserAndRole(authServer, "mfa-user", []string{"role"}, nil)
require.NoError(t, err)
userClient, err := testServer.NewClient(TestUser(user.GetName()))
require.NoError(t, err)
// Create an auth connector.
samlConnector, err := types.NewSAMLConnector("saml", types.SAMLConnectorSpecV2{
AssertionConsumerService: "http://localhost:65535/acs", // not called
Issuer: "test",
SSO: "https://localhost:65535/sso", // not called
AttributesToRoles: []types.AttributeMapping{
// not used. can be any name, value but role must exist
{Name: "groups", Value: "admin", Roles: user.GetRoles()},
},
})
require.NoError(t, err)
_, err = authServer.UpsertSAMLConnector(ctx, samlConnector)
require.NoError(t, err)
// Convert the user to an SSO user for this auth connector.
userCreatedAt := authServer.clock.Now()
user.SetCreatedBy(types.CreatedBy{
Time: userCreatedAt,
Connector: &types.ConnectorRef{
ID: samlConnector.GetKind(),
Type: samlConnector.GetName(),
},
})
_, err = authServer.UpsertUser(ctx, user)
require.NoError(t, err)
// No MFA devices should exist for the user.
resp, err := userClient.GetMFADevices(ctx, &proto.GetMFADevicesRequest{})
require.NoError(t, err)
require.Empty(t, resp.Devices)
// prepare a passwordless device.
passkeyName := "passkey"
passkey, err := RegisterTestDevice(ctx, userClient, passkeyName, proto.DeviceType_DEVICE_TYPE_WEBAUTHN, nil, WithPasswordless())
require.NoError(t, err, "RegisterTestDevice")
passkeyWebAuthnHandler := func(t *testing.T, challenge *proto.MFAAuthenticateChallenge) *proto.MFAAuthenticateResponse {
require.NotNil(t, challenge.WebauthnChallenge, "nil Webauthn challenge")
mfaResp, err := passkey.SolveAuthn(challenge)
require.NoError(t, err, "SolveAuthn")
return mfaResp
}
resp, err = userClient.GetMFADevices(ctx, &proto.GetMFADevicesRequest{})
require.NoError(t, err)
require.Len(t, resp.Devices, 1)
webauthnDevice := resp.Devices[0]
// Update the auth connector to enable SSO MFA.
samlConnector.SetMFASettings(&types.SAMLConnectorMFASettings{
Enabled: true,
Issuer: "test",
Sso: "https://localhost:65535/sso", // not called
})
require.NoError(t, err)
_, err = authServer.UpsertSAMLConnector(ctx, samlConnector)
require.NoError(t, err)
// Ephemeral sso device should show up in the list now. It can't be deleted.
resp, err = userClient.GetMFADevices(ctx, &proto.GetMFADevicesRequest{})
assert.NoError(t, err)
assert.Len(t, resp.Devices, 2)
expectSSODev, err := types.NewMFADevice(samlConnector.GetDisplay(), samlConnector.GetName(), userCreatedAt, &types.MFADevice_Sso{
Sso: &types.SSOMFADevice{
ConnectorId: samlConnector.GetName(),
ConnectorType: samlConnector.GetKind(),
DisplayName: samlConnector.GetDisplay(),
},
})
require.NoError(t, err)
assert.Equal(t, []*types.MFADevice{webauthnDevice, expectSSODev}, resp.Devices)
testDeleteMFADevice(ctx, t, userClient, mfaDeleteTestOpts{
deviceName: "saml",
authHandler: passkeyWebAuthnHandler,
checkErr: func(t require.TestingT, err error, _ ...interface{}) {
assert.ErrorAs(t, err, new(*trace.BadParameterError))
assert.ErrorContains(t, err, "cannot delete ephemeral SSO MFA device")
}},
)
// Last non-SSO, passwordless device can be deleted now.
testDeleteMFADevice(ctx, t, userClient, mfaDeleteTestOpts{
deviceName: passkeyName,
authHandler: passkeyWebAuthnHandler,
checkErr: require.NoError,
})
}
func TestDeletingLastPasswordlessDevice(t *testing.T) {
testServer := newTestTLSServer(t)
authServer := testServer.Auth()
clock := testServer.Clock().(clockwork.FakeClock)
ctx := context.Background()
tests := []struct {
name string
setup func(t *testing.T, username string, userClient *authclient.Client, pwdlessDev *TestDevice)
checkErr require.ErrorAssertionFunc
}{
{
name: "NOK no other MFA device",
setup: func(*testing.T, string, *authclient.Client, *TestDevice) {},
checkErr: func(t require.TestingT, err error, _ ...any) {
require.ErrorContains(t,
err,
"cannot delete the last MFA device for this user",
"Unexpected error deleting last passwordless device",
)
},
},
{
name: "OK extra passwordless device",
setup: func(t *testing.T, username string, userClient *authclient.Client, pwdlessDev *TestDevice) {
_, err := RegisterTestDevice(ctx, userClient, "another-passkey", proto.DeviceType_DEVICE_TYPE_WEBAUTHN, pwdlessDev, WithPasswordless())
require.NoError(t, err, "RegisterTestDevice failed")
},
checkErr: require.NoError,
},
{
name: "OK password set with other WebAuthn device",
setup: func(t *testing.T, username string, userClient *authclient.Client, pwdlessDev *TestDevice) {
err := authServer.UpsertPassword(username, []byte("living on the edge"))
require.NoError(t, err, "UpsertPassword")
_, err = RegisterTestDevice(
ctx, userClient, "another-dev", proto.DeviceType_DEVICE_TYPE_WEBAUTHN, pwdlessDev)
require.NoError(t, err, "RegisterTestDevice")
},
checkErr: require.NoError,
},
{
name: "OK password set with other TOTP device",
setup: func(t *testing.T, username string, userClient *authclient.Client, pwdlessDev *TestDevice) {
err := authServer.UpsertPassword(username, []byte("living on the edge"))
require.NoError(t, err, "UpsertPassword")
_, err = RegisterTestDevice(
ctx, userClient, "another-dev", proto.DeviceType_DEVICE_TYPE_TOTP, pwdlessDev, WithTestDeviceClock(clock))
require.NoError(t, err, "RegisterTestDevice")
},
checkErr: require.NoError,
},
{
name: "OK SSO user with other device",
setup: func(t *testing.T, username string, userClient *authclient.Client, pwdlessDev *TestDevice) {
user, err := authServer.GetUser(ctx, username, false)
require.NoError(t, err, "GetUser")
user.SetCreatedBy(types.CreatedBy{
Connector: &types.ConnectorRef{},
})
_, err = authServer.UpsertUser(ctx, user)
require.NoError(t, err, "UpsertUser")
_, err = RegisterTestDevice(
ctx, userClient, "another-dev", proto.DeviceType_DEVICE_TYPE_WEBAUTHN, pwdlessDev)
require.NoError(t, err, "RegisterTestDevice")
},
checkErr: require.NoError,
},
{
name: "NOK password set but no other MFAs",
setup: func(t *testing.T, username string, userClient *authclient.Client, pwdlessDev *TestDevice) {
err := authServer.UpsertPassword(username, []byte("living on the edge"))
require.NoError(t, err, "UpsertPassword")
},
checkErr: func(t require.TestingT, err error, _ ...any) {
require.ErrorContains(t,
err,
"cannot delete the last MFA device for this user",
"Unexpected error deleting last passwordless device",
)
},
},
{
name: "NOK other MFAs, but no password set",
setup: func(t *testing.T, username string, userClient *authclient.Client, pwdlessDev *TestDevice) {
_, err := RegisterTestDevice(
ctx, userClient, "another-dev", proto.DeviceType_DEVICE_TYPE_TOTP, pwdlessDev, WithTestDeviceClock(clock))
require.NoError(t, err, "RegisterTestDevice")
},
checkErr: func(t require.TestingT, err error, _ ...any) {
require.ErrorContains(t,
err,
"cannot delete last passwordless credential for user",
"Unexpected error deleting last passwordless device",
)
},
},
{
name: "NOK other MFAs, but no password set, passwordless is off",
setup: func(t *testing.T, _ string, userClient *authclient.Client, pwdlessDev *TestDevice) {
// Register a non-passwordless device without adding a password.
_, err := RegisterTestDevice(ctx, userClient, "another-dev", proto.DeviceType_DEVICE_TYPE_TOTP, pwdlessDev, WithTestDeviceClock(clock))
require.NoError(t, err, "RegisterTestDevice")
authPref, err := authServer.GetAuthPreference(ctx)
require.NoError(t, err, "GetAuthPreference")
// Turn off passwordless authentication.
authPref.SetAllowPasswordless(false)
_, err = authServer.UpsertAuthPreference(ctx, authPref)
require.NoError(t, err, "UpsertAuthPreference")
},
checkErr: func(t require.TestingT, err error, _ ...any) {
require.ErrorContains(t,
err,
"cannot delete last passwordless credential for user",
"Unexpected error deleting last passwordless device",
)
},
},
}
for i, test := range tests {
t.Run(test.name, func(t *testing.T) {
// Enable MFA support.
authPref, err := types.NewAuthPreference(types.AuthPreferenceSpecV2{
Type: constants.Local,
SecondFactors: []types.SecondFactorType{
types.SecondFactorType_SECOND_FACTOR_TYPE_OTP,
types.SecondFactorType_SECOND_FACTOR_TYPE_WEBAUTHN,
},
Webauthn: &types.Webauthn{
RPID: "localhost",
},
})
require.NoError(t, err)
_, err = authServer.UpsertAuthPreference(ctx, authPref)
require.NoError(t, err)
// Create a fake user.
username := fmt.Sprintf("mfa-user-%d", i)
user, _, err := CreateUserAndRole(authServer, username, []string{"role"}, nil)
require.NoError(t, err)
userClient, err := testServer.NewClient(TestUser(user.GetName()))
require.NoError(t, err)
// No MFA devices should exist for a new user.
resp, err := userClient.GetMFADevices(ctx, &proto.GetMFADevicesRequest{})
require.NoError(t, err)
require.Empty(t, resp.Devices)
// Add the passwordless device to be deleted.
pwdlessDevName := "pwdless-dev"
pwdlessDev, err := RegisterTestDevice(
ctx, userClient, pwdlessDevName, proto.DeviceType_DEVICE_TYPE_WEBAUTHN, nil, WithPasswordless())
require.NoError(t, err)
// Case-specific setup.
test.setup(t, username, userClient, pwdlessDev)
// Delete the last passwordless device.
testDeleteMFADevice(ctx, t, userClient, mfaDeleteTestOpts{
deviceName: pwdlessDevName,
authHandler: func(t *testing.T, ch *proto.MFAAuthenticateChallenge) *proto.MFAAuthenticateResponse {
require.NotNil(t, ch.WebauthnChallenge, "nil Webauthn challenge")
mfaResp, err := pwdlessDev.SolveAuthn(ch)
require.NoError(t, err, "SolveAuthn")
return mfaResp
},
checkErr: test.checkErr,
})
})
}
}
type mfaDevices struct {
clock clockwork.Clock
webOrigin string
TOTPName string
TOTPDev *TestDevice
WebName string
WebDev *TestDevice
}
func (d *mfaDevices) totpAuthHandler(t *testing.T, challenge *proto.MFAAuthenticateChallenge) *proto.MFAAuthenticateResponse {
require.NotNil(t, challenge.TOTP, "nil TOTP challenge")
if c, ok := d.clock.(clockwork.FakeClock); ok {
c.Advance(30 * time.Second)
}
mfaResp, err := d.TOTPDev.SolveAuthn(challenge)
require.NoError(t, err, "SolveAuthn")
return mfaResp
}
func (d *mfaDevices) webAuthHandler(t *testing.T, challenge *proto.MFAAuthenticateChallenge) *proto.MFAAuthenticateResponse {
require.NotNil(t, challenge.WebauthnChallenge, "nil Webauthn challenge")
mfaResp, err := d.WebDev.SolveAuthn(challenge)
require.NoError(t, err, "SolveAuthn")
return mfaResp
}
func addOneOfEachMFADevice(t *testing.T, userClient *authclient.Client, clock clockwork.Clock, origin string) mfaDevices {
const totpName = "totp-dev"
const webName = "webauthn-dev"
ctx := context.Background()
totpDev, err := RegisterTestDevice(
ctx, userClient, totpName, proto.DeviceType_DEVICE_TYPE_TOTP, nil /* authenticator */, WithTestDeviceClock(clock))
require.NoError(t, err, "RegisterTestDevice(totp)")
webDev, err := RegisterTestDevice(
ctx, userClient, webName, proto.DeviceType_DEVICE_TYPE_WEBAUTHN, totpDev /* authenticator */)
require.NoError(t, err, "RegisterTestDevice(totp)")
return mfaDevices{
clock: clock,
webOrigin: origin,
TOTPName: totpName,
WebName: webName,
TOTPDev: totpDev,
WebDev: webDev,
}
}
type mfaAddTestOpts struct {
deviceName string
deviceType proto.DeviceType
deviceUsage proto.DeviceUsage
authHandler func(*testing.T, *proto.MFAAuthenticateChallenge) *proto.MFAAuthenticateResponse
checkAuthErr require.ErrorAssertionFunc
registerHandler func(*testing.T, *proto.MFARegisterChallenge) *proto.MFARegisterResponse
checkRegisterErr require.ErrorAssertionFunc
assertRegisteredDev func(*testing.T, *types.MFADevice)
}
func testAddMFADevice(ctx context.Context, t *testing.T, authClient *authclient.Client, opts mfaAddTestOpts) {
authChal, err := authClient.CreateAuthenticateChallenge(ctx, &proto.CreateAuthenticateChallengeRequest{
Request: &proto.CreateAuthenticateChallengeRequest_ContextUser{
ContextUser: &proto.ContextUser{},
},
ChallengeExtensions: &mfav1.ChallengeExtensions{
Scope: mfav1.ChallengeScope_CHALLENGE_SCOPE_MANAGE_DEVICES,
},
})
require.NoError(t, err, "CreateAuthenticateChallenge")
authnSolved := opts.authHandler(t, authChal)
registerChal, err := authClient.CreateRegisterChallenge(ctx, &proto.CreateRegisterChallengeRequest{
ExistingMFAResponse: authnSolved,
DeviceType: opts.deviceType,
DeviceUsage: opts.deviceUsage,
})
opts.checkAuthErr(t, err)
if err != nil {
return
}
registerSolved := opts.registerHandler(t, registerChal)
addResp, err := authClient.AddMFADeviceSync(ctx, &proto.AddMFADeviceSyncRequest{
NewDeviceName: opts.deviceName,
NewMFAResponse: registerSolved,
DeviceUsage: opts.deviceUsage,
})
opts.checkRegisterErr(t, err)
switch {
case err != nil:
return
case opts.assertRegisteredDev != nil:
opts.assertRegisteredDev(t, addResp.Device)
}
}
type mfaDeleteTestOpts struct {
deviceName string
authHandler func(*testing.T, *proto.MFAAuthenticateChallenge) *proto.MFAAuthenticateResponse
checkErr require.ErrorAssertionFunc
}
func testDeleteMFADevice(ctx context.Context, t *testing.T, authClient *authclient.Client, opts mfaDeleteTestOpts) {
// Issue and solve authn challenge.
authnChal, err := authClient.CreateAuthenticateChallenge(ctx, &proto.CreateAuthenticateChallengeRequest{
Request: &proto.CreateAuthenticateChallengeRequest_ContextUser{
ContextUser: &proto.ContextUser{},
},
ChallengeExtensions: &mfav1.ChallengeExtensions{
Scope: mfav1.ChallengeScope_CHALLENGE_SCOPE_MANAGE_DEVICES,
},
})
require.NoError(t, err, "CreateAuthenticateChallenge")
authnSolved := opts.authHandler(t, authnChal)
// Attempt deletion.
opts.checkErr(t,
authClient.DeleteMFADeviceSync(ctx, &proto.DeleteMFADeviceSyncRequest{
DeviceName: opts.deviceName,
ExistingMFAResponse: authnSolved,
}))
}
func TestCreateAppSession_deviceExtensions(t *testing.T) {
ctx := context.Background()
testServer := newTestTLSServer(t)
authServer := testServer.Auth()
// Create an user for testing.
user, _, err := CreateUserAndRole(authServer, "llama", []string{"llama"}, nil)
require.NoError(t, err, "CreateUserAndRole failed")
// Register an application.
app, err := types.NewAppV3(
types.Metadata{
Name: "llamaapp",
}, types.AppSpecV3{
URI: "http://localhost:8080",
PublicAddr: "llamaapp.example.com",
})
require.NoError(t, err, "NewAppV3 failed")
appServer, err := types.NewAppServerV3FromApp(app, "host", uuid.New().String())
require.NoError(t, err, "NewAppServerV3FromApp failed")
_, err = authServer.UpsertApplicationServer(ctx, appServer)
require.NoError(t, err, "UpsertApplicationServer failed")
wantExtensions := &tlsca.DeviceExtensions{
DeviceID: "device1",
AssetTag: "assettag1",
CredentialID: "credentialid1",
}
tests := []struct {
name string
modifyUser func(u *TestIdentity)
assertCert func(t *testing.T, cert *x509.Certificate)
}{
{
name: "no device extensions",
// Absence of errors is enough here, this is mostly to make sure the base
// scenario works.
},
{
name: "user with device extensions",
modifyUser: func(u *TestIdentity) {
lu := u.I.(authz.LocalUser)
lu.Identity.DeviceExtensions = *wantExtensions
u.I = lu
},
assertCert: func(t *testing.T, cert *x509.Certificate) {
gotIdentity, err := tlsca.FromSubject(cert.Subject, cert.NotAfter)
require.NoError(t, err, "FromSubject failed")
if diff := cmp.Diff(*wantExtensions, gotIdentity.DeviceExtensions, protocmp.Transform()); diff != "" {
t.Errorf("DeviceExtensions mismatch (-want +got)\n%s", diff)
}
},
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
u := TestUser(user.GetName())
if test.modifyUser != nil {
test.modifyUser(&u)
}
userClient, err := testServer.NewClient(u)
require.NoError(t, err, "NewClient failed")
session, err := userClient.CreateAppSession(ctx, &proto.CreateAppSessionRequest{
Username: user.GetName(),
PublicAddr: app.GetPublicAddr(),
ClusterName: testServer.ClusterName(),
})
require.NoError(t, err, "CreateAppSession failed")
block, _ := pem.Decode(session.GetTLSCert())
require.NotNil(t, block, "Decode failed")
gotCert, err := x509.ParseCertificate(block.Bytes)
require.NoError(t, err, "ParserCertificate failed")
if test.assertCert != nil {
test.assertCert(t, gotCert)
}
})
}
}
func TestGenerateUserCerts_deviceExtensions(t *testing.T) {
ctx := context.Background()
testServer := newTestTLSServer(t)
// Create an user for testing.
user, _, err := CreateUserAndRole(testServer.Auth(), "llama", []string{"llama"}, nil)
require.NoError(t, err, "CreateUserAndRole failed")
key, err := cryptosuites.GenerateKeyWithAlgorithm(cryptosuites.ECDSAP256)
require.NoError(t, err, "GenerateKeyWithAlgorithm failed")
publicKeyPEM, err := keys.MarshalPublicKey(key.Public())
require.NoError(t, err, "MarshalPublicKey failed")
wantExtensions := &tlsca.DeviceExtensions{
DeviceID: "device1",
AssetTag: "assettag1",
CredentialID: "credentialid1",
}
tests := []struct {
name string
modifyUser func(u *TestIdentity)
assertCert func(t *testing.T, cert *x509.Certificate)
}{
{
name: "no device extensions",
// Absence of errors is enough here, this is mostly to make sure the base
// scenario works.
},
{
name: "user with device extensions",
modifyUser: func(u *TestIdentity) {
lu := u.I.(authz.LocalUser)
lu.Identity.DeviceExtensions = *wantExtensions
u.I = lu
},
assertCert: func(t *testing.T, cert *x509.Certificate) {
gotIdentity, err := tlsca.FromSubject(cert.Subject, cert.NotAfter)
require.NoError(t, err, "FromSubject failed")
if diff := cmp.Diff(*wantExtensions, gotIdentity.DeviceExtensions, protocmp.Transform()); diff != "" {
t.Errorf("DeviceExtensions mismatch (-want +got)\n%s", diff)
}