Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

show amount receiving instead of giving on button #416

Closed
chadwhitacre opened this issue Dec 8, 2012 · 7 comments
Closed

show amount receiving instead of giving on button #416

chadwhitacre opened this issue Dec 8, 2012 · 7 comments

Comments

@chadwhitacre
Copy link
Contributor

@dianaclarke points out that showing the amount you give violates the anonymity principle. Instead of showing just the text "Gittip," how about if we show the amount the person is receiving? That'd be more like GitHub's "Star" widget and Twitter's "Follow" widget. We should show a depressed button if we wanted to indicate tippage without giving away the amount.

One problem is that we have limited width due to the hard-coded iframe embed.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@chadwhitacre
Copy link
Contributor Author

Eh, @rummik?

@rummik
Copy link
Contributor

rummik commented Sep 16, 2013

@whit537 The new widgets don't have the <iframe> width issue. But yeah, I can see the problem with how it works right now. Should we make it so widgets can't look at this after it's changed?

Edit: Hm. Actually, thinking about it, this may conflict with some of the widget ideas -- maybe we should have an option to not show amount giving in widgets? (not just publicly, but also privately)

@chadwhitacre
Copy link
Contributor Author

Right, the case here is when someone is watching over your shoulder (pairing, at a sprint or conference, meetup, etc.). They can see what you're tipping to whom. We need to think about dropping back and only ever showing "Gittip" on the button.

@rummik
Copy link
Contributor

rummik commented Sep 17, 2013

That's what I mean -- let the user have an option decide if they want to protect against this ("don't show me how much I'm tipping when I visit other sites"). I personally don't mind having it this way, since people could catch who I'm tipping by looking over my shoulder while I'm on www.gittip.com anyway. When we have things like, say, #1167, or #1215, this problem will likely exist there too.

@nobodxbodon
Copy link
Contributor

AFAIK it's done.

@mattbk
Copy link
Contributor

mattbk commented Jan 15, 2017

@nobodxbodon, you should check the grtp.co repo amd reticket widget stuff there if it needs to be.

@nobodxbodon
Copy link
Contributor

@mattbk actually I checked the one served on shields.io, and seemed it's showing amount receiving. Thus I closed this one. Sorry I should have made it clear.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants