Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeventSubscriptionServer ignore schema validation errors #52

Open
vodkar opened this issue Sep 25, 2020 · 0 comments
Open

GeventSubscriptionServer ignore schema validation errors #52

vodkar opened this issue Sep 25, 2020 · 0 comments

Comments

@vodkar
Copy link

vodkar commented Sep 25, 2020

  • GraphQL AioWS version: 0.3.1
  • Python version: Python 3.8.5
  • Operating System: Debian

Description

GeventSubscriptionServer ignore any schema validation errors.
I use Altair GraphQL client. When I send subscription request with schema text errors (for example: wrong field name), this error is covered by GeventSubscriptionServer and just raise "A subscription must return an observable"

I think problem in following lines in gevent.py, line 74:75:

assert isinstance(execution_result, Observable), \ "A subscription must return an observable"

There's check only for Observable, but in case of schema error its return ExecutionResult object with errors, then assert is failed, another error is raising

What I Did

Any subscription query with any schema error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant