Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible logic issue with unreachable code #242

Closed
ambientlight opened this issue Apr 11, 2019 · 2 comments
Closed

Possible logic issue with unreachable code #242

ambientlight opened this issue Apr 11, 2019 · 2 comments

Comments

@ambientlight
Copy link

Was looking into subscriptions and found this:

https://github.com/graphql-python/graphql-core/blob/9333075c657e91e563c09add8464f3758e317749/graphql/execution/executor.py#L306-L312

The desired intention here is merging field subscriptions into single observable?

@ekampf
Copy link
Contributor

ekampf commented Apr 15, 2019

It does like like return observable shouldn't be there.

@Cito
Copy link
Member

Cito commented Jan 24, 2020

The reason for this is probably that the whole code is only tested and functional when there is only one field anyway. I have now made the code more clear in this regard.

Closing this here. If anybody wants to solve this properly, this is still open as #194.

@Cito Cito closed this as completed Jan 24, 2020
Cito added a commit that referenced this issue Jan 24, 2020
Allow merging multiple fields into one result.
@Cito Cito added the duplicate label Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants