Skip to content

Unlist Support for Apollo Federation? #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
steve-gray opened this issue Feb 2, 2023 · 4 comments
Closed

Unlist Support for Apollo Federation? #554

steve-gray opened this issue Feb 2, 2023 · 4 comments

Comments

@steve-gray
Copy link
Contributor

steve-gray commented Feb 2, 2023

There's #528 tracking the wider issue, however in the interim I'd suggest potentially some changes to the package. At the moment it'd be fairly misleading for anyone who picks up this package to see those release notes, or the examples folder and be able to assume it supports federation. At a mechanical level you can basically stitch schemas, but all of the smarts for routers, directives, the ability to actually connect entities from subgraphs today is non-existent.

To avoid confusion (like how I got caught out), I'd suggest maybe....

  • Remove the examples and any references to Apollo federation.
  • Update the release notes for 1.4.0 to indicate more explicitly that this is a non-feature today.
@pavelnikolov
Copy link
Member

@steve-gray I'm sorry to hear that you have had such an experience. I'll consider improving the documentation to explicitly mention that we do not offer full feature coverage for Apollo Federation. It's just a bare minimum _service field in the schema.

@steve-gray
Copy link
Contributor Author

All good.

The main issue is that the schema annotations are unsupported as are the other entity lookups - meaning it's not possible to use this to power a sub-graph. We're using Apollos federation router.

Hopefully support for that would be easier to achieve / however in the here and now we're just having to face up to a very painful migration of a massive project to gcqlgen at short notice.

It's something that took the utility from "I love this package and I'm a graph-gopher till I die..." to zero once we had the need.

@pavelnikolov
Copy link
Member

As requested:

  1. I have mentioned in the Apollo Federation example:

NOTE: This library doesn't support the full Apollo Federation subgraph spec!

  1. I added a clarification in the v1.4 release notes that we have only added support for the _service field.

@pavelnikolov
Copy link
Member

pavelnikolov commented Mar 5, 2023

@steve-gray I'm happy to announce that this library now fully support all features from the GraphQL spec need in order to implement the Apollo Federation Subgraph spec.

For more information check the README.md: https://github.com/graph-gophers/graphql-go/tree/master/example/federation/compatibility

The code needed to support Apollo Federation is in the latest master branch. I expect to release it with v1.6.0 soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants