Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: SSE - emit slashing events #36

Closed
eth2353 opened this issue Aug 30, 2024 · 3 comments
Closed

Feature: SSE - emit slashing events #36

eth2353 opened this issue Aug 30, 2024 · 3 comments

Comments

@eth2353
Copy link

eth2353 commented Aug 30, 2024

It would be great if Grandine could add support for these SSE events ( attester_slashing , proposer_slashing ) so that validator clients can react quickly to slashing events by e.g. shutting down.

All other CL client implementations already emit these events.

Introduced in the Beacon API spec v2.5.0 - https://github.com/ethereum/beacon-APIs/releases/tag/v2.5.0

@Tumas
Copy link
Member

Tumas commented Oct 1, 2024

Hey, @eth2353 support for slashing SSE events has been added to develop. Did you have the chance to test this?

@eth2353
Copy link
Author

eth2353 commented Oct 1, 2024

Thanks Tumas, appreciate it! I did not get an email notification for that commit, so I hadn't noticed.

I haven't figured out a good way to actually test this end-to-end, will probably need to play around with kurtosis and let you know how it went. Feel free to close this issue in the meantime.

@eth2353
Copy link
Author

eth2353 commented Oct 8, 2024

Hi @Tumas I have now tested both of these SSE events using Kurtosis and both work well, thanks for this!

@eth2353 eth2353 closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants