Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faust passes invalid --class-name and --super-class-name identifiers to generated code #1120

Open
Pri-yan-shu opened this issue Feb 13, 2025 · 0 comments

Comments

@Pri-yan-shu
Copy link

Pri-yan-shu commented Feb 13, 2025

Faust doesn't correctly modify --class-name and --super-class-name to valid c++ identifiers and generates uncompilable c++ code. Its bigger issue with faust2.. scripts using filename as classname, for instance faust2lv2, so filenames that are valid (for instance starting with a digit or containing hyphen) result in error during the compilation of the generated c++ code.

@Pri-yan-shu Pri-yan-shu changed the title Faust doesn't check --class-name and --super-class-name values for validity Faust passes invalid --class-name and --super-class-name identifiers to generated code Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant